Skip to content

Branch for release 2020.4#11910

Merged
feerrenrut merged 21 commits into
betafrom
branchForRelease2020.4
Dec 8, 2020
Merged

Branch for release 2020.4#11910
feerrenrut merged 21 commits into
betafrom
branchForRelease2020.4

Conversation

@feerrenrut

@feerrenrut feerrenrut commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

This takes the latest master (alpha) commit, to merge into beta.

Open PR's intended for 2020.4 should be re-targeted to the beta branch.

Note: this should be completed as a merge, not squash merge

zcorpan and others added 21 commits November 20, 2020 14:24
Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>
…10048)

* UX improvements for diskMGMT Graphical View
Co-authored-by: Reef Turner <reef@nvaccess.org>
When wx controls (combo-box, edit, etc.) have an associated labels, disable the associated label when the control is disabled.
Fixes #11809
Co-authored-by: Reef Turner <reef@nvaccess.org>
Fixes #11752
When reading characters that do not have any description in NVDA, a 'no content'
utterance can be produced. In this case the empty string is the last
'command' in the sequence passed to 'ensureEndUtterance', resulting in
the sequence not being given an indexCommand or an EndUtteranceCommand.
The indexCommand is required for the cancellable speech processing, to
be able to track which utterance a cancellableSpeechCommand belongs to.

Noticed and fixed a similar issue for 'latestCancelledUtteranceIndex': zero is a might
be a valid index. Only no index (None) should take this path.
* support invalid:spelling,grammar in IAccessible2 text attributes.

* Add system test for ARIA invalid spelling and grammar

* Fix linting issue

* Add extra info to ariaInvalid spelling and grammar test noting that it is not yet standard ARIA.

* Update what's new.
Co-authored-by: Leonard de Ruijter <L.de.Ruijter@sevenp.nl>
When 'Hover for cell routing' was unchecked, the brailleviewer would attempt
to unbind a not yet bound event causing wx to crash.

Keep track of the binding and only unbind if it has been already bound.
fixes #11846
# Added an appModule for Winword to gather the code specific to MSWord.

The code common to MS Word and other applications (such as 
MS Outlook) should not be stored in this module but in common 
object files such as NVDAObjects/window/winword.py

For now this appModule contains only toggleChangeTracking script 
since this feature is available in Word only.

Co-authored-by: Leonard de Ruijter <leonardder@users.noreply.github.com>
Co-authored-by: Reef Turner <reef@nvaccess.org>
Fixes #9428.

Calculator raises UIA notification event (live region change event in older releases and in some screens) to communication progress and results of calculations. However, this results in repetitions if typed character announcement is turned on. Thus, as part of this new app module, suppress repetitive announcements if possible.

* Windows 10 Calculator: remove live region handler.

In the old days of Calculator, live regions were used from various places, including calculator expressions, unit conversion and other places. Now that uIA notification event and some name change events will take care of this, remove live region change event support code (and also becasue NVDA itself will announce live regions if possible).

* Calculator: updates to notification and name change event handling due to UI changes in 2019.

* Calculator: gather a list of UIA automation ID's for objects that should not allow NVDA to repeatedly announce calculation results or expressions. Re #9428.

With the advent of always on top i.e. compact overlay mode in Calculator, additional UIA automation ID's were added for calculation results and expressions in overlay mode. Because of line length concerns, the additional ID's, together with the existing ones, are now housed inside a list of known ID's causing NVDA to announce expressions repeatedly. Not only this makes it easy to add more ID's in the future (either through NVDA Core or add-ons), it improves readability for name change and notification event handler methods (and keeps the lines short).

* Calculator: support always on top (compact overlay) mode.

In August 2019, Calculator app (preview) added always on top mode. As the name suggests, this puts standard calculator on top of other windows. Because of this, UIA tree has been changed, so work with old and new tree structure.

* Calculator: announce more notifications except display updated activity ID.

Display updated activity ID should be ignored unless needed, as it causes repetitions when entering calculations while speak typed characters is on.
#11875)

This reverts (the reversion) commit 53cecfd.

* Set to an empty string instead of trying to construct a string from a nullptr
…r (PR #11883)

Follow on from #11880.

* Avoid unit conversion result repetition. 

If a user presses Escape several times while focused on either 'convert from' or 'converts into' fields in unit converter, NVDA will announce the field again after a number is entered. This was traced to result announcement flag that is checked from name change event handler. To avoid repetition, add UIA Automation Id's for these elements (Value1 and Value2, respectively) to a list of no result announcement Id's.

* Remove unit conversion Automation Id's from name change event handler element check

Now that unit converter element Automation Id's were added to no result anouncement list, there's no need to check for these in name change event handler.

* Announce calculation results in compact overlay (always on top) mode. 

Always on top (compact overlay) mode uses a different UIA Automation Id to represent results. Therefore add this to a list of Id's to be checked when handling results script (Enter, Numpad Enter, Escape).
* No longer override isAlive on WordBrowseModeDocument

* Always log an error when we couldn't update a tree interceptor

* api.setFocusObject: log the exception if there is an error updating a treeInterceptor.

Co-authored-by: Michael Curran <mick@nvaccess.org>
Fix an issue introduced with #11865, which incorrectly used the return value of _checkForCancellations
to indicate error/success, rather than utterance canceled (correctly) or no cancellations found.

Instead, an exception is raised when the method can not complete, and the error is logged in this case.
@feerrenrut feerrenrut changed the base branch from master to beta December 7, 2020 07:34
@feerrenrut

Copy link
Copy Markdown
Contributor Author

I accidentally used master as the base branch, this is fixed now.

@feerrenrut feerrenrut merged commit ad43362 into beta Dec 8, 2020
@feerrenrut feerrenrut deleted the branchForRelease2020.4 branch December 8, 2020 02:42
@nvaccessAuto nvaccessAuto added this to the 2020.4 milestone Dec 8, 2020
feerrenrut added a commit that referenced this pull request Dec 8, 2020
Branch for release 2020.4 PR #11910
feerrenrut added a commit that referenced this pull request Dec 15, 2020
Several commits were missed when branching for Release 2020.4 (see PR #11910) which selected commit f99644e, however there are 3 commits after that and 325be94 (inclusive) before the version number was updated.

Merge to the 2020.4 beta:
- Fix: NVDA no longer fails to restart when running from sources and cw… 3737e3c
- MS Word: report the number of pts of line spacing when line spacing t… 9c0b649
- Fix-up of #10973: Fallback to POSITION_FIRST when reporting formattin… 325be94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants