Change “Focus Highlight” to “Visual Highlight”#11878
Merged
Merged
Conversation
feerrenrut
suggested changes
Nov 30, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Thanks @OzancanKaratas
Contributor
|
This is looking good, except for the testing, some ideas:
I've done this testing for this PR now. |
Contributor
|
I think this will need a line in the change log, since it is a user visible feature that has changed it's name. I'll add something to that effect. |
Collaborator
Author
|
The test before reverting the changes worked fine. The current test works fine too. |
feerrenrut
approved these changes
Dec 1, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Thanks @OzancanKaratas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11700
Summary of the issue:
In #11700, @CyrilleB79 said that the name of the Focus Highlight feature should have a user friendly name.
Description of how this pull request fixes the issue:
All contexts was changed as Visual Highlight (including user guide). Please remind me if there is anything I forgot.
Testing performed:
I didn't tested.
Known issues with pull request:
None
Change log entry:
I think it not necessary.