Revert live region changes to mshtml virtual buffer#11838
Conversation
AAClause
left a comment
There was a problem hiding this comment.
Thank for the fix. I tested the try build, issue solved for me! :)
| This file is a part of the NVDA project. | ||
| URL: http://www.nvda-project.org/ | ||
| Copyright 2006-2020 NV Access Limited, Google LLC, Leonard de Ruijter | ||
| Copyright 2006-2015 NVDA contributers. |
There was a problem hiding this comment.
| Copyright 2006-2015 NVDA contributers. | |
| Copyright 2006-2015 NVDA contributors. |
| || this->storageNode->ariaLiveIsAdditionsRelevant | ||
| ) | ||
| ) { | ||
| if(this->storageNode->ariaLiveNode&&this->storageNode->ariaLiveNode!=this->storageNode&&!this->storageNode->ariaLiveIsBusy&&(this->storageNode->ariaLiveIsTextRelevant||this->storageNode->ariaLiveIsAdditionsRelevant)) { |
There was a problem hiding this comment.
I think that it's better to Split long if statements onto several lines. Do you have a reason to change this here and others places?
| This file is a part of the NVDA project. | ||
| URL: http://www.nvda-project.org/ | ||
| Copyright 2006-2020 NV Access Limited, Google LLC, Leonard de Ruijter | ||
| Copyright 2006-2015 NVDA contributers. |
There was a problem hiding this comment.
| Copyright 2006-2015 NVDA contributers. | |
| Copyright 2006-2015 NVDA contributors. |
| } else { | ||
| this->ariaLiveAtomicNode=parent?parent->ariaLiveAtomicNode:NULL; | ||
| } | ||
| LOG_DEBUG(L"preProcessLiveRegion: ariaLiveNode "<<ariaLiveNode<<L", ariaLiveIsTextRelevant "<<ariaLiveIsTextRelevant<<L", ariaLiveIsAdditionsRelevant "<<ariaLiveIsAdditionsRelevant<<L", ariaLiveIsBusy "<<ariaLiveIsBusy<<L", ariaLiveAtomicNode "<<ariaLiveAtomicNode); |
There was a problem hiding this comment.
I assume that this line should be restored and the (new) comment should be removed
|
Note that this pr simply reverts the changes done in #9079, it simply brings back the code to the state it had in NVDA 2020.3. I personally would like to leave this as is. |
|
Ok, lets revert this, hopefully we can get to the bottom of the issue via #11834 in order to bring IE back into line. |
This reverts commit 53cecfd.
Link to issue number:
Fixes #11834
Summary of the issue:
Changes in #9079 caused crashes in the virtual buffer code when viewing a browsable message.
Description of how this pull request fixes the issue:
Revert the MSHTML changes from #9079. This means that we're still using the new live region code in Firefox and Chrome. While this introduces an inconsistency, I think there are several justifications.
Testing performed:
Tested that browseable messages no longer crash.
Known issues with pull request:
None
Change log entry:
In pr, as it modifies an existing entry.