Fix frequent error sounds with Cancellable speech#11887
Merged
Conversation
Fix an issue introduced with #11865, which incorrectly used the return value of _checkForCancellations to indicate error/success, rather than utterance canceled (correctly) or no cancellations found. Instead, an exception is raised when the method can not complete, and the error is logged in this case.
michaelDCurran
approved these changes
Dec 1, 2020
Collaborator
|
I'm getting errors like this pretty often: Could this be a debugWarning or warning instead? |
Contributor
Author
|
@LeonarddeR this PR intends to fix exactly that issue. Now you should only get that error when there is a true error case, rather than when there was a cancelled utterance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
When moving through email items in focus mode in Gmail, errors occur, you may have to wait for the utterance to finish speaking.
Fix an issue introduced with #11865, which incorrectly used the return value of _checkForCancellations
to indicate error/success, rather than utterance canceled (correctly) or no cancellations found.
Description of how this pull request fixes the issue:
Instead, an exception is raised when the method can not complete, and the error is logged in this case.
Testing performed:
Ran locally with cancellable speech enabled.
Known issues with pull request:
None
Change log entry:
None