Hi,

Will plan to experiment with it (likely tonight provided my health permits).

Thanks for reminding me about that flag.

Hi,

Regarding script decorator issue, I'm thinking it has to do with name mangling.

Overall work: I'm willing to delay this work until Python 3 comes to NVDA. Doing so could also give me more time to experiment with things here and there.

Thanks.

Hi,

Regarding live region change event: after looking at the UIA live region flag and my own code, it might be possible, but we run into an important design limitation: when @michaelDCurran designed live region change handling for UIA objects in 2017 (with revisions afterwards), it was intended that all live regions will be announced, provided that texts are different and there is a reasonable time interval between event firings. Part of the reason for writing that function in the Calculator app module was to detect which regions should be announced, because it isn't quite possible to name all live region descriptors in one go and lump them into an overlay class. Perhaps the newly opened Calculator will change that, but that'll take months to hunt and fix. Besides, detecting live regions and defining the regions to be silenced will introduce code duplication like so:

1. Descriptors of live regions in chooseNVDAObjectOverlayClasses.
2. Flagging which live regions to announce in obj._get__shouldAllowUIALiveRegionChangeEvent.

Both will describe the same thing. Resolving the underlying issue that causes this code duplication will involve opening up other possibilities to silence live regions.

Thanks.

Hi,

If talking about the result, it isn't necessarily a focused object because it'll be announced as soon as enter key is pressed to finalize the expression.

Thanks.

Hi,

Update: after doing more tests, it appears @LeonarddeR's intuition was correct - disabling live region announcement will do. But first, I'll let people test possible changes via my add-on before editing the pull request.

Thanks.

Hi,

Two things:

1. Actually, name change event handling was modified - we still need to keep live regions alive for date calculation at least.
2. Flake8 gives all sorts of problems with indents. If I fix E121 (visual appearance), it comes back with E101 (mixed spaces and indents). I think it would be best to ignore visual appearance bit.

Thanks.

Hi,

Actually, ET128.

Hi,

Calculator has gone through yet another UI redesign, this time due to "always on" i.e. picture-in-picture mode support. The redesign also rearranges the UIA tree, which breaks this PR and the app module that ships with Windows 10 App Essentials. I'll prepare a fix after testing this week's Insider Preview build (if any).

Thanks.

To @LeonarddeR: ready for another round of review, if you are willing.

Thanks,

Hi,

Update: since the last time we talked, graphing mode has been added to Calculator, but supporting that is beyond the scope of this PR. Giving this PR a bit of break due to backlog (otherwise ready for review).

Thanks.

Hi,

Update: it turns out the solution is simpler than I thought: rather than adding individual UIA notification activity ID's, we can just take care of one or two corner cases (DisplayUpdate ID should not be announced unless noted otherwise). This is thanks to the fact that Calculator app source code is hosted on GitHub (MIT license), so we now know the full list of activity ID's.

Thanks.

@josephsl There are a number of remaining review actions on this PR. Please can you check them out comment / resolve / make changes as appropriate. Then we can move onto a second review.

Hi,

Addressed in subsequent commits - will mark them as such. Thanks for the reminder.

@LeonarddeR since you reviewed this previously, and the feedback has now all been addressed, could you please review this again.

Hi,

Two issues found, to be resolved in a PR (coming today):

1. Results are not announced in compact overlay (always on top) mode. This will require tweaking result announcement script to include a second UIA Automation Id. A much better solution is locating and announcing results element (next year because I would like to test this solution with users through WinTenApps add-on).
2. In unit converter, source and target values (and units) are announced twice if focused on these fields, caused by notification and name change events being fired one after another. This can be resolved by adding two new Automation Id's to a list of Id's that should be checked for suppressing announcements.

Thanks.