Fix-up of #9079: Move _nvdaControllerInternal_reportLiveRegion to the end of interface definitions to fix add-ons installs.#11877
Merged
michaelDCurran merged 1 commit intonvaccess:masterfrom Nov 30, 2020
Conversation
… definitions to fix add-ons installs. Fix for nvaccess#11867
michaelDCurran
approved these changes
Nov 30, 2020
Member
michaelDCurran
left a comment
There was a problem hiding this comment.
Technically only the changes to the idl and acf files are necessary, not the c or def files. However, having the order maintained in all of them is probably a good thing so I'll accept this as is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11867
Summary of the issue:
PR #9079 added a new function to the NVDA Helper interface. This made it impossible to install add-ons when older version of NVDA is installed on the system.
Description of how this pull request fixes the issue:
If
_nvdaControllerInternal_reportLiveRegionis placed at the end of the interface definition files this problem does not occur anymore. Since I can't see any reason not to do that_nvdaControllerInternal_reportLiveRegionis moved to the end.Testing performed:
With NVDA 2019.2.1 installed and build from this PR running as portable:
Known issues with pull request:
Perhaps the fact that new functions need to be added ad the end of interface files not to break backward compatibility should be documented somewhere?
Change log entry:
None needed - this issue is not in a release yet.