Windows 10 Calculator (follow-up to PR #9429): results announcement in compact overlay and unit converter#11883
Merged
Conversation
…access#11880. If a user presses Escape several times while focused on either 'convert from' or 'converts into' fields in unit converter, NVDA will announce the field again after a number is entered. This was traced to result announcement flag that is checked from name change event handler. To avoid repetition, add UIA Automation Id's for these elements (Value1 and Value2, respectively) to a list of no result announcement Id's.
…me change event handler element check. Re nvaccess#11880. Now that unit converter element Automation Id's were added to no result nanouncement list, there's no need to check for these in name change event handler.
…y (always on top) mode. Re nvaccess#11881. Always on top (compact overlay) mode uses a different UIA Automation Id to represent results. Therefore add this to a list of Id's to be checked when handling results script (Enter, Numpad Enter, Escape).
feerrenrut
reviewed
Dec 1, 2020
| @@ -51,7 +55,7 @@ def event_nameChange(self, obj, nextHandler): | |||
| ): | |||
| # For unit conversion, UIA notification event presents much better messages. | |||
Contributor
There was a problem hiding this comment.
I think this comment needs to be updated?
Contributor
Author
|
Hi, I’m wondering the same thing. I think it would be better to remove that comment altogether, or slightly tweak it (at least for now, I think it would be better to remove it as beta cycle is approaching). Thanks.
|
Contributor
Author
|
Hi, actually, I can update this comment in just a moment. Thanks.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Follow-up to #9429
Fixes #11880
Fixes #11881
Summary of the issue:
Improve result announcements in compact overlay mode and unit converters. Specifically:
Description of how this pull request fixes the issue:
For compact overlay: add a UIA Automation Id used in alwasy on top mode to represent calculator results, resulting in results being announced when Enter, Numpad Enter, or Escape is pressed.
Unit converter: NVDA will no longer announce convert from/converts into fields multiple times, resolved by adding "Value1" and "Value2" Automation Id strings for unit conversion fields to a list of no result announcement list.
Testing performed:
Tested via Windows 10 App Essentials and from source code with Calculator version 10.2010 and later running on Windows 10 Version 20H2.
Known issues with pull request:
None
Change log entry:
Not needed (see #9429).