Experimentially add a system test for APG checkbox#11827
Merged
Conversation
bff5d15 to
cd12e35
Compare
This comment has been minimized.
This comment has been minimized.
feerrenrut
previously approved these changes
Nov 18, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Welcome to the NVDA project @zcorpan, and thanks for the contribution 🎉
Co-authored-by: Reef Turner <feerrenrut@users.noreply.github.com>
feerrenrut
approved these changes
Nov 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Summary of the issue:
This is an addition of a system test using the APG "checkbox" example, following the assertions from ARIA AT for the first test for this APG example: https://w3c.github.io/aria-at/tests/checkbox/index.html
The approach for this PR is the same as the existing APG test. However, to make it more scalable and maintainable, I'd like to explore other ways to run the ARIA AT tests. I can report a new issue to discuss this further.
Description of how this pull request fixes the issue:
Testing performed:
Ran
scons systemTestslocally.Known issues with pull request:
Change log entry:
Section: New features, Changes, Bug fixes