No longer override isAlive on UIA WordBrowseModeDocument#11885
Merged
Conversation
… treeInterceptor.
michaelDCurran
approved these changes
Dec 1, 2020
michaelDCurran
left a comment
Member
There was a problem hiding this comment.
I think the reason why isAlive was originally overridden like that was simply just that UIABrowseMode and some of the other base classes did not yet exist when starting to write the UIA WordDocument support, and I think I just needed something that worked at the time.
Having tested this a bit myself, I believe what you have done is the right approach.
However, I have gone ahead and added exc_info=True to the log.error in api.py as it is important to be able to still see the actual traceback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#11741
Summary of the issue:
On WordBrowseModeDocument, isAlive was overridden in a way that it would always return True. This would block a clean up of the interceptor.
Description of how this pull request fixes the issue:
Testing performed:
Tested that #11741 no longer occurs. When the TI wasn't killed correctly, it generated an update error that caused speech to cancel somehow.
Known issues with pull request:
Change log entry:
Probably not worth mentioning