Fix crash opening BrailleViewer#11873
Merged
Merged
Conversation
When 'Hover for cell routing' was unchecked, the brailleviewer would attempt to unbind a not yet bound event causing wx to crash. Keep track of the binding and only unbind if it has been already bound. fixes #11846
LeonarddeR
approved these changes
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #11846
Summary of the issue:
When 'Hover for cell routing' was unchecked, the braille viewer would attempt
to unbind a not yet bound event causing wx to crash.
Description of how this pull request fixes the issue:
Keep track of the binding and only unbind if it has been already bound.
Testing performed:
Known issues with pull request:
None
Change log entry:
None