Fix up of PR 9843: Once again report when copying text in browse mode in MS Word.#11848
Merged
Conversation
LeonarddeR
approved these changes
Nov 21, 2020
Contributor
|
Is #11851 trying to fix the same issue as this PR? |
Contributor
|
@CyrilleB79 wrote:
Indeed, my bad, I did not notice @lukaszgo1 already proposed this fix before posting. |
Contributor
|
Tested. It is working on my side. |
michaelDCurran
approved these changes
Nov 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #11839
Summary of the issue:
PR #9843 changed signature of the
copyToClipboardmethod on textInfos but this change has not been reflected inWordDocumentTextInfoclass.Description of how this pull request fixes the issue:
Signature of the
copyToClipboardfor MS Word now matches one from the base class.Testing performed:
Ensured that text can once again be reported when copying it in MS Word when in browse mode.
Known issues with pull request:
Change log entry:
None needed this is not in a release