Fix-up of PR #9843: Impact MS Word browse mode#11851
Closed
JulienCochuyt wants to merge 1 commit into
Closed
Conversation
Contributor
|
Is this PR resolving the same issue as #11848? |
Contributor
Author
|
Closing in favor of #11848. |
Contributor
|
@JulienCochuyt wrote:
I know this PR is closed. However, to just for information to answer this question left over: |
Contributor
Author
|
@CyrilleB79, thank you for pointing this out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fix-up of PR #9843
Issue reported by @Adriani90 in #9843 (comment)
Summary of the issue:
PR #9843 missed to impact MS Word browse mode.
Description of how this pull request fixes the issue:
Add and handle the new
notifyparameter toWordDocumentTextInfo.copyToClipboardTesting performed:
Copied text in MS Word in both focus and browse mode.
Known issues with pull request:
This change is effective in browse mode.
In focus mode, I couldn't find yet where the announce comes from.
Change log entry:
On method
TextInfo.copyToClipboard, PR #9843 added a newnotifyparameter.Should this change be mentioned in the "Changes for developers" section?