[Saved objects] Add support for version on create & bulkCreate when overwriting a document by gmmorris · Pull Request #75172 · elastic/kibana

gmmorris · 2020-08-17T15:12:32Z

Summary

Adds support for version one the SavedObjectsClient's create api.
This sallows us to retain Optimistic concurrency control when using create to overwrite an existing document.

For example:

savedObjectsClient.create(
      'known-type',
      {
        attrOne: 'one',
        attrTwo: 'two',
      },
      { id: 'uuid-to-overwrite', overwrite: true, version: '=snjr5dorY' }
    );

Checklist

Delete any items that are not applicable to this PR.

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

gmmorris · 2020-08-18T10:04:43Z

@elasticmachine merge upstream

This reverts commit 814b98d.

This reverts commit d4820e1.

jportner · 2020-08-18T13:19:46Z

WRT d4820e1 and CI failures:

It looks like all the CI failures can boiled down to three types of tests:

Import
Copy to space
Loading sample data

I'm not 100% sure about loading sample data, but copy to space does use import under the hood.

You could try filtering out the version inside importSavedObjectsFromStream and see if that fixes the issue:

kibana/src/core/server/saved_objects/import/import_saved_objects.ts

Lines 69 to 73 in 36f0c75

    
           // Create objects in bulk 
        
           const bulkCreateResult = await savedObjectsClient.bulkCreate(filteredObjects, { 
        
             overwrite, 
        
             namespace, 
        
           });

This reverts commit caa1834.

This reverts commit 7bd360c.

* master: Skip failing test in CI (elastic#75266) [Task Manager] time out work when it overruns in poller (elastic#74980) [Drilldowns] misc improvements & fixes (elastic#75276) Small README note on bumping memory for builds (elastic#75247) [Security Solution][Detections] Adds exception modal tests (elastic#74596) [Dashboard] Sample data link does not work (elastic#75262) [Dashboard First] Unlink from Library Action With ReferenceOrValueEmbeddable (elastic#74905) [Form lib] Fix issue where serializer on fields are called on every change (elastic#75166) convert processor labels to sentence case (elastic#75278) [Monaco] Refactor the way XJSON grammar checker gets registered (elastic#75160) Clarify no documents error message when filtering by is_training (elastic#75227) [Lens] Fix crash when two layers xychart switches to pie (elastic#75267) [Observability Homepage] Fix console error because of side effect (elastic#75258) [Usage Collection] Add `legacy=true` option to the /api/stats request in the docs (elastic#75146) [ML] Functional tests - re-activate DFA test suites (elastic#75257) GS providers improvements (elastic#75174) [Visualize] First version of by-value visualize editor (elastic#72256)

elasticmachine · 2020-08-18T21:18:27Z

Pinging @elastic/kibana-platform (Team:Platform)

elasticmachine · 2020-08-18T23:17:12Z

Pinging @elastic/ingest-management (Team:Ingest Management)

pgayvallet

LGTM for platform changes.

Added @jportner as a reviewer as this may directly impact the changes on the SO sharing feature.

src/core/server/saved_objects/service/lib/repository.test.js

kibanamachine · 2020-08-19T13:04:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4297f2a

Build metrics

✅ unchanged

History

💚 Build #68833 succeeded a0fc384
💔 Build #68824 failed 4dfcf10
💚 Build #68693 succeeded caa1834
💔 Build #68536 failed 814b98d
💔 Build #68481 failed d4820e1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jportner

LGTM!

…verwriting a document (elastic#75172) Adds support for `version` one the SavedObjectsClient's create api. This sallows us to retain Optimistic concurrency control when using create to overwrite an existing document.

Resolves conflicts from #75172.

* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...

…verwriting a document (elastic#75172) Adds support for `version` one the SavedObjectsClient's create api. This sallows us to retain Optimistic concurrency control when using create to overwrite an existing document. # Conflicts: # src/core/server/saved_objects/service/lib/repository.ts

…verwriting a document (#75172) (#75447) Adds support for `version` one the SavedObjectsClient's create api. This sallows us to retain Optimistic concurrency control when using create to overwrite an existing document.

…when overwriting a document (#75172) (#75498) * [Saved objects] Add support for version on create & bulkCreate when overwriting a document (#75172) Adds support for `version` one the SavedObjectsClient's create api. This sallows us to retain Optimistic concurrency control when using create to overwrite an existing document.

…e when overwriting a document (elastic#75172)" This reverts commit 9698a07.

…kCreate when overwriting a document (#75172) (#75498)" This reverts commit 00836e5.

…kCreate when overwriting a document (elastic#75172) (elastic#75498)" This reverts commit 00836e5.

…writing a document (#76280) * Revert "Fix more broken usages of `bulkCreate` (#76005) (#76131)" This reverts commit 44a017b. * Revert "Filter saved object `version` during legacy import (#75597) (#75793)" This reverts commit 6e82885. * Revert "[7.9] [Saved objects] Add support for version on create & bulkCreate when overwriting a document (#75172) (#75498)" This reverts commit 00836e5.

gmmorris added 3 commits August 17, 2020 12:20

added version to saved object creation

13c4ec4

added version to saved object bulk creation

d4820e1

added missing core docs

814b98d

elasticmachine and others added 3 commits August 18, 2020 04:04

Merge branch 'master' into saved-objects/version-on-create

3f49f67

Revert "added missing core docs"

7bd360c

This reverts commit 814b98d.

Revert "added version to saved object bulk creation"

caa1834

This reverts commit d4820e1.

gmmorris added 5 commits August 18, 2020 15:39

Revert "Revert "added version to saved object bulk creation""

8f3dfc8

This reverts commit caa1834.

Revert "Revert "added missing core docs""

c4e8c59

This reverts commit 7bd360c.

omit version from SO import/export

c391446

remove version when loading sample data

a0fc384

gmmorris added Feature:Saved Objects Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.10.0 v7.9.1 v8.0.0 labels Aug 18, 2020

gmmorris marked this pull request as ready for review August 18, 2020 21:18

gmmorris requested a review from a team August 18, 2020 21:18

gmmorris requested a review from a team as a code owner August 18, 2020 21:18

gmmorris added the release_note:enhancement label Aug 18, 2020

neptunian approved these changes Aug 18, 2020

View reviewed changes

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 18, 2020

pgayvallet requested a review from jportner August 19, 2020 09:42

pgayvallet approved these changes Aug 19, 2020

View reviewed changes

src/core/server/saved_objects/service/lib/repository.test.js Outdated Show resolved Hide resolved

fixed typo

4297f2a

jportner approved these changes Aug 19, 2020

View reviewed changes

gmmorris merged commit 9698a07 into elastic:master Aug 19, 2020

gmmorris mentioned this pull request Aug 19, 2020

[7.x] [Saved objects] Add support for version on create & bulkCreate when overwriting a document (#75172) #75447

Merged

jportner added a commit that referenced this pull request Aug 19, 2020

Merge branch 'master' into security/sharing-saved-objects-1.5

69516b6

Resolves conflicts from #75172.

gmmorris mentioned this pull request Aug 19, 2020

[7.9] [Saved objects] Add support for version on create & bulkCreate when overwriting a document (#75172) #75498

Merged

jportner mentioned this pull request Aug 20, 2020

Importing Beats dashboards results in an error #75596

Closed

neptunian added a commit to neptunian/kibana that referenced this pull request Aug 21, 2020

Revert "[Saved objects] Add support for version on create & bulkCreat…

da74e65

…e when overwriting a document (elastic#75172)" This reverts commit 9698a07.

mikecote added a commit that referenced this pull request Aug 31, 2020

Revert "[7.9] [Saved objects] Add support for version on create & bul…

b33dbcb

…kCreate when overwriting a document (#75172) (#75498)" This reverts commit 00836e5.

mikecote added a commit to mikecote/kibana that referenced this pull request Aug 31, 2020

Revert "[7.9] [Saved objects] Add support for version on create & bul…

d57e68c

…kCreate when overwriting a document (elastic#75172) (elastic#75498)" This reverts commit 00836e5.

mikecote removed the v7.9.1 label Aug 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Saved objects] Add support for version on create & bulkCreate when overwriting a document#75172

[Saved objects] Add support for version on create & bulkCreate when overwriting a document#75172
gmmorris merged 12 commits intoelastic:masterfrom
gmmorris:saved-objects/version-on-create

gmmorris commented Aug 17, 2020 •

edited

Loading

Uh oh!

gmmorris commented Aug 18, 2020

Uh oh!

jportner commented Aug 18, 2020

Uh oh!

elasticmachine commented Aug 18, 2020

Uh oh!

elasticmachine commented Aug 18, 2020

Uh oh!

pgayvallet left a comment

Uh oh!

Uh oh!

kibanamachine commented Aug 19, 2020

Uh oh!

jportner left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

gmmorris commented Aug 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

gmmorris commented Aug 18, 2020

Uh oh!

jportner commented Aug 18, 2020

Uh oh!

elasticmachine commented Aug 18, 2020

Uh oh!

elasticmachine commented Aug 18, 2020

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Aug 19, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

jportner left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gmmorris commented Aug 17, 2020 •

edited

Loading