[ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. by walterra · Pull Request #74953 · elastic/kibana

walterra · 2020-08-13T13:44:40Z

Summary

Fixes error reporting when annotations fail to load for Anomaly Explorer and Single Metric Viewer.

Previously, Anomaly Explorer ended up with a completely empty page when annotations failed to load. Single Metric Viewer would not fail to load, but it would make no difference for the user if existing annotations failed to load of if there were simply no existing annotations. Only in dev console an error message would be visible.

Now a callout is shown when annotations fail to load:

Anomaly Explorer

Single Metric Viewer

For testing, you can create an evironment that fails to load annotations by using the commands shown in the original issue under To reproduce the issue without the update progress:

The same approach is used for functional tests to create an environment with an annotations index with wrong mappings.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-08-13T13:44:42Z

Pinging @elastic/ml-ui (:ml)

x-pack/plugins/ml/public/application/explorer/explorer.js

x-pack/plugins/ml/public/application/explorer/explorer_utils.js

x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js

walterra · 2020-08-14T10:52:40Z

@elasticmachine merge upstream

walterra · 2020-08-14T11:00:38Z

@elasticmachine retest

qn895 · 2020-08-14T13:51:39Z

x-pack/test/api_integration/apis/transform/index.ts

    });

-    loadTestFile(require.resolve('./delete_transforms'));
+    // loadTestFile(require.resolve('./delete_transforms'));


nit: commented code

Thanks for spotting this! Fixed in bcce968.

walterra · 2020-08-17T14:00:42Z

@elasticmachine merge upstream

qn895 · 2020-08-17T15:23:01Z

Tested and LGTM

walterra · 2020-08-18T14:05:05Z

@elasticmachine merge upstream

walterra · 2020-08-18T15:04:33Z

@elasticmachine merge upstream

peteharverson

LGTM, although I've been unable to reproduce the original issue using the steps in #74935

walterra · 2020-08-19T07:40:43Z

@elasticmachine merge upstream

kibanamachine · 2020-08-19T10:02:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 627b820

Build metrics

async chunks size

id	value	diff	baseline
ml	8.0MB	+6.8KB	8.0MB

History

💔 Build #68983 failed e2fe95e
💔 Build #68772 failed b33a014
💔 Build #68742 failed 528b08c
💔 Build #68447 failed 1dcccc0
💔 Build #68170 failed 6997b4b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

… annotations. (elastic#74953) Fixes error reporting when annotations fail to load for Anomaly Explorer and Single Metric Viewer. Previously, Anomaly Explorer ended up with a completely empty page when annotations failed to load. Single Metric Viewer would not fail to load, but it would make no difference for the user if existing annotations failed to load of if there were simply no existing annotations. Only in dev console an error message would be visible. Now a callout is shown when annotations fail to load.

… annotations. (elastic#74953) Fixes error reporting when annotations fail to load for Anomaly Explorer and Single Metric Viewer. Previously, Anomaly Explorer ended up with a completely empty page when annotations failed to load. Single Metric Viewer would not fail to load, but it would make no difference for the user if existing annotations failed to load of if there were simply no existing annotations. Only in dev console an error message would be visible. Now a callout is shown when annotations fail to load. # Conflicts: # x-pack/test/functional/services/ml/navigation.ts

… annotations. (#74953) (#75409) Fixes error reporting when annotations fail to load for Anomaly Explorer and Single Metric Viewer. Previously, Anomaly Explorer ended up with a completely empty page when annotations failed to load. Single Metric Viewer would not fail to load, but it would make no difference for the user if existing annotations failed to load of if there were simply no existing annotations. Only in dev console an error message would be visible. Now a callout is shown when annotations fail to load.

… annotations. (#74953) (#75410) Fixes error reporting when annotations fail to load for Anomaly Explorer and Single Metric Viewer. Previously, Anomaly Explorer ended up with a completely empty page when annotations failed to load. Single Metric Viewer would not fail to load, but it would make no difference for the user if existing annotations failed to load of if there were simply no existing annotations. Only in dev console an error message would be visible. Now a callout is shown when annotations fail to load.

* master: (112 commits) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) Fix docs in trigger alerting UI (elastic#75363) [SIEM] Fixes search bar Cypress test (elastic#74833) Add libnss3.so to Dockerfile template (reporting) (elastic#75370) [Discover] Create field_button and add popovers to sidebar (elastic#73226) [Reporting] Network Policy: Do not throw from the intercept handler (elastic#75105) [Reporting] Increase capture.timeouts.openUrl to 1 minute (elastic#75207) Allow routes to specify the idle socket timeout in addition to the payload timeout (elastic#73730) [src/dev/build] remove node-version from snapshots (elastic#75303) [ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components (elastic#74886) [Canvas] Remove dependency on legacy expressions APIs (elastic#74885) Skip failing test in CI (elastic#75266) [Task Manager] time out work when it overruns in poller (elastic#74980) [Drilldowns] misc improvements & fixes (elastic#75276) Small README note on bumping memory for builds (elastic#75247) ...

* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...

[ML] Fix error reporting for annotations.

87f90ce

walterra added bug Fixes for quality problems that affect the customer experience regression :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.10.0 v7.9.1 labels Aug 13, 2020

walterra requested review from darnautov, jgowdyelastic and qn895 August 13, 2020 13:44

walterra requested a review from a team as a code owner August 13, 2020 13:44

walterra self-assigned this Aug 13, 2020

qn895 reviewed Aug 13, 2020

View reviewed changes

x-pack/plugins/ml/public/application/explorer/explorer.js Outdated Show resolved Hide resolved

qn895 reviewed Aug 13, 2020

View reviewed changes

x-pack/plugins/ml/public/application/explorer/explorer.js Outdated Show resolved Hide resolved

qn895 reviewed Aug 13, 2020

View reviewed changes

x-pack/plugins/ml/public/application/explorer/explorer_utils.js Show resolved Hide resolved

qn895 reviewed Aug 13, 2020

View reviewed changes

x-pack/plugins/ml/public/application/timeseriesexplorer/timeseriesexplorer.js Outdated Show resolved Hide resolved

walterra added the release_note:fix label Aug 14, 2020

walterra added 3 commits August 14, 2020 08:57

[ML] Use error message utils.

83ffd4b

Merge branch 'master' into ml-fix-annotations-error

4de8ff3

[ML] e2e tests for annotations.

0958376

walterra requested a review from pheyos August 14, 2020 09:32

Merge branch 'master' into ml-fix-annotations-error

41c4ccd

qn895 reviewed Aug 14, 2020

View reviewed changes

walterra added 2 commits August 14, 2020 16:16

[ML] Fix accidentally commented code.

bcce968

Merge branch 'master' into ml-fix-annotations-error

6997b4b

Merge branch 'master' into ml-fix-annotations-error

1dcccc0

qn895 approved these changes Aug 17, 2020

View reviewed changes

Merge branch 'master' into ml-fix-annotations-error

528b08c

walterra requested a review from peteharverson August 18, 2020 14:05

Merge branch 'master' into ml-fix-annotations-error

b33a014

peteharverson approved these changes Aug 18, 2020

View reviewed changes

elasticmachine and others added 2 commits August 19, 2020 01:40

Merge branch 'master' into ml-fix-annotations-error

e2fe95e

[ML] Remove accindetally added line.

627b820

walterra merged commit 2559d90 into elastic:master Aug 19, 2020

walterra deleted the ml-fix-annotations-error branch August 19, 2020 10:07

walterra mentioned this pull request Aug 19, 2020

[7.x] [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (#74953) #75409

Merged

walterra mentioned this pull request Aug 19, 2020

[7.9] [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (#74953) #75410

Merged

pheyos added the test_ui_functional label Aug 25, 2020

lcawl mentioned this pull request Sep 2, 2020

[DOCS] 7.9.1 Release Notes #76289

Merged

1 task

Conversation

walterra commented Aug 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Anomaly Explorer

Single Metric Viewer

Checklist

Uh oh!

elasticmachine commented Aug 13, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

walterra commented Aug 14, 2020

Uh oh!

walterra commented Aug 14, 2020

Uh oh!

qn895 Aug 14, 2020

Choose a reason for hiding this comment

Uh oh!

walterra Aug 14, 2020

Choose a reason for hiding this comment

Uh oh!

walterra commented Aug 17, 2020

Uh oh!

qn895 commented Aug 17, 2020

Uh oh!

walterra commented Aug 18, 2020

Uh oh!

walterra commented Aug 18, 2020

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

walterra commented Aug 19, 2020

Uh oh!

kibanamachine commented Aug 19, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

walterra commented Aug 13, 2020 •

edited

Loading