Skip to content

[Index template] Add filters to simulate preview#74497

Merged
sebelga merged 8 commits intoelastic:masterfrom
sebelga:index-templates/filter-simulate-view
Aug 19, 2020
Merged

[Index template] Add filters to simulate preview#74497
sebelga merged 8 commits intoelastic:masterfrom
sebelga:index-templates/filter-simulate-view

Conversation

@sebelga
Copy link
Copy Markdown
Contributor

@sebelga sebelga commented Aug 6, 2020 •
edited
Loading

This PR adds filters on top of the simulate preview inside the flyout so the user can hide part of the final composite template he is not interested in.

Screenshot 2020-08-11 at 16 05 08

Screenshot 2020-08-11 at 16 03 57

Screenshot 2020-08-11 at 16 04 23

Screenshot 2020-08-11 at 16 04 33

Screenshot 2020-08-11 at 16 04 52

[EDIT] In this PR I also made the recommended copy text changes from @debadair. I updated the PR with the latest screenshots.

@sebelga sebelga requested a review from a team as a code owner August 6, 2020 10:35
@sebelga sebelga added Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.10.0 v8.0.0 labels Aug 6, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 6, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sebelga sebelga added the release_note:skip Skip the PR/issue when compiling release notes label Aug 6, 2020
@sebelga sebelga requested a review from cjcenizal August 6, 2020 10:36
@sebelga
Copy link
Copy Markdown
Contributor Author

sebelga commented Aug 18, 2020

@elasticmachine merge upstream

@sebelga
Copy link
Copy Markdown
Contributor Author

sebelga commented Aug 18, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 18, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
indexManagement 499 +1 498

async chunks size

id value diff baseline
indexManagement 1.5MB +5.0KB 1.5MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal requested review from jloleysens and removed request for cjcenizal August 18, 2020 21:06
jloleysens
jloleysens approved these changes Aug 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @sebelga ! 🎉

Really good use of useRef to preserve the users selection throughout the wizard.

Tested locally, works as expected.

I would say adding a component integration test would be nice (to ensure edge case of having no items selected or no data to filter works). But not essential.

@sebelga
Copy link
Copy Markdown
Contributor Author

sebelga commented Aug 19, 2020

Thanks for the review @jloleysens !
I created this issue #75431 to not forget about adding the component integration test 👍

@sebelga sebelga merged commit 53c765e into elastic:master Aug 19, 2020
@sebelga sebelga deleted the index-templates/filter-simulate-view branch August 19, 2020 14:13
@sebelga sebelga mentioned this pull request Aug 19, 2020
Merged
sebelga added a commit that referenced this pull request Aug 19, 2020
@sebelga @elasticmachine
[7.x] [Index template] Add filters to simulate preview (#74497) (#75432)
b50c90e 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 19, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
fd42b0c 
* master: (30 commits)
  [code coverage] always download node before team assignment (elastic#75424)
  [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302)
  [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555)
  skip flaky suite (elastic#75440)
  skip flaky suite (elastic#75386)
  [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172)
  [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138)
  MOAR RAM (elastic#75423)
  [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315)
  [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499)
  [ML] Inference models management (elastic#74978)
  [Monitoring] Migrate karma tests (elastic#75301)
  [Index template] Add filters to simulate preview (elastic#74497)
  Bump and consolidate dependencies (elastic#75360)
  [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364)
  Update Node.js to version 10.22.0 (elastic#75254)
  [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953)
  [Discover] Fix histogram cloud tests (elastic#75268)
  Uiactions to navigate to visualize or maps (elastic#74121)
  Use prefix search invis editor field/agg combo box (elastic#75290)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees

No one assigned

Labels

Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebelga @elasticmachine @kibanamachine @jloleysens