[Functional]Table Vis increase sleep time in order filter to be applied#75138
Merged
stratoula merged 3 commits intoelastic:masterfrom Aug 19, 2020
Merged
[Functional]Table Vis increase sleep time in order filter to be applied#75138stratoula merged 3 commits intoelastic:masterfrom
stratoula merged 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
liza-mae
approved these changes
Aug 19, 2020
Contributor
liza-mae
left a comment
There was a problem hiding this comment.
LGTM, I know you just want to check if more time helps this, but it is best to replace sleeps with something event driven.
Contributor
Author
|
@liza-mae if it fails again then I will have to do a refactor as it is kind of tricky. So let's try this super simple solution and then proceed with something else |
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
Aug 19, 2020
…ed (elastic#75138) * Increase sleep time in order filter to be applied * revert Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 19, 2020
* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #74434.
This test fails because it fetches the data before the filter manages to be applied. It doesn't fail often and I couldn't replicate it but I want to try to give more time to sleep to check if it is going to solve the problem.
https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/93/
Checklist
Delete any items that are not applicable to this PR.