[ML] Inference models management#74978
Conversation
x-pack/plugins/ml/public/application/services/ml_api_service/inference.ts
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/services/ml_api_service/inference.ts
Show resolved
Hide resolved
|
Curious about James's question about the license check for the endpoints but aside from that the code LGTM 👍 |
|
Gave this a quick test and functionality works well. I like the split between the new tabs for Jobs and the Models 💯 . One thing I wonder if it's worth doing is make the font size for the tabs same as the ones we have in the DFA Job List. Another issue I came across is if we have an invalid (?) inference object, then expanding it will cause a blank page. The Another item, which I think might be on your todo list already is to have an indicator that the models were successfully deleted. |
thanks for spotting this @alvarezmelissa87, I switched some panels to use |
...ata_frame_analytics/pages/analytics_management/components/models_management/expanded_row.tsx
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/page.tsx
Show resolved
Hide resolved
...data_frame_analytics/pages/analytics_management/components/models_management/models_list.tsx
Outdated
Show resolved
Hide resolved
...data_frame_analytics/pages/analytics_management/components/models_management/models_list.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/application/routing/routes/data_frame_analytics/models_list.tsx
Outdated
Show resolved
Hide resolved
...ata_frame_analytics/pages/analytics_management/components/models_management/expanded_row.tsx
Show resolved
Hide resolved
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest edits and confirmed stats tab updates on refresh. LGTM!
* [ML] init tabs * [ML] init inference API service in UI * [ML] server-side routes * [ML] basic table * [ML] support deletion * [ML] delete multiple models * [ML] WIP expanded row * [ML] fix types * [ML] expanded row * [ML] fix types * [ML] fix i18n id * [ML] change server-side permission check * [ML] refactor types * [ML] show success toast on model deletion, fix models counter * [ML] update expanded row * [ML] pipelines stats * [ML] use refresh observable * [ML] endpoint to fetch associated pipelines * [ML] update the endpoint to fetch associated pipelines * [ML] show pipelines definition in expanded row * [ML] change stats layout * [ML] fix headers * [ML] change breadcrumb title * [ML] fetch models config with pipelines * [ML] change default size to 1000 * [ML] fix collections keys, fix double fetch on initial page load * [ML] adjust models deletion text * [ML] fix DFA jobs on the management page * [ML] small tabs in expanded row * [ML] fix headers text * [ML] fix models fetching without pipelines get permissions * [ML] stats rendering as a description list * [ML] fix i18n id * [ML] remove an extra copyright comment, add selectable messages * [ML] update stats on refresh
* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...
* [ML] init tabs * [ML] init inference API service in UI * [ML] server-side routes * [ML] basic table * [ML] support deletion * [ML] delete multiple models * [ML] WIP expanded row * [ML] fix types * [ML] expanded row * [ML] fix types * [ML] fix i18n id * [ML] change server-side permission check * [ML] refactor types * [ML] show success toast on model deletion, fix models counter * [ML] update expanded row * [ML] pipelines stats * [ML] use refresh observable * [ML] endpoint to fetch associated pipelines * [ML] update the endpoint to fetch associated pipelines * [ML] show pipelines definition in expanded row * [ML] change stats layout * [ML] fix headers * [ML] change breadcrumb title * [ML] fetch models config with pipelines * [ML] change default size to 1000 * [ML] fix collections keys, fix double fetch on initial page load * [ML] adjust models deletion text * [ML] fix DFA jobs on the management page * [ML] small tabs in expanded row * [ML] fix headers text * [ML] fix models fetching without pipelines get permissions * [ML] stats rendering as a description list * [ML] fix i18n id * [ML] remove an extra copyright comment, add selectable messages * [ML] update stats on refresh
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |



Summary
This PR introduces basic listing capabilities for inference trained models.
The table contains the following columns:
Available actions include
It's also possible to delete multiple models. In case the models have associated pipelines there is a warning message shown in a dialog.
Content of the expandable row:
Checklist