Uiactions to navigate to visualize or maps by stratoula · Pull Request #74121 · elastic/kibana

stratoula · 2020-08-03T16:42:03Z

Summary

Changes the way that discover navigates to Visualize or Maps apps. We use two triggers:

VISUALIZE_FIELD for handling the navigation to visualize editor (except geo field)
VISUALIZE_GEO_FIELDfor handling the navigation to tilemaps or maps app

Both tilemaps and maps app register to VISUALIZE_GEO_FIELD. It is checked whether the maps app is enabled and the tilemaps is hidden or not. If it is not hidden and the maps app is enabled the user has two options to visualize a geo field. Otherwise, the Visualize button will navigate the user to the plugin that is compatible.

Update: As tilemaps are going to be deprecated we decided to not register any actions for legacy mapping visualizations.
This means that if the maps app is not enabled, the visualize button for geo fields won't appear on Discover.

Except for that, the previous functionality is the same. We had functional tests to check the navigation from discover to visualize and from discover to the maps app. I added a new one to check the navigation to tilemaps.

I have also run a flaky test server https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/741/

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md
Unit or functional tests were updated or added to match the most common scenarios
This was checked for cross-browser compatibility

…functionality

elasticmachine · 2020-08-04T13:17:22Z

Pinging @elastic/kibana-app (Team:KibanaApp)

src/plugins/discover/public/application/components/sidebar/lib/visualize_trigger_utils.ts

src/plugins/discover/public/application/components/sidebar/discover_field_details.tsx

timroes · 2020-08-13T13:47:35Z

x-pack/plugins/maps/public/plugin.ts

+declare module '../../../../src/plugins/ui_actions/public' {
+  export interface ActionContextMapping {
+    [ACTION_VISUALIZE_GEO_FIELD]: VisualizeFieldContext;
+  }
+}


@stratoula could we then so far move that type declaraction into the plugin where it's defined?

src/plugins/discover/public/application/components/sidebar/lib/visualize_trigger_utils.ts

src/plugins/visualize/common/constants.ts

…action and other fixes

stratoula · 2020-08-17T06:23:44Z

@elasticmachine merge upstream

src/plugins/discover/public/application/components/sidebar/discover_field_details.tsx

src/plugins/discover/public/application/components/sidebar/lib/visualize_trigger_utils.ts

x-pack/plugins/maps/public/url_generator.ts

x-pack/plugins/maps/public/url_generator.test.ts

src/plugins/visualize/public/actions/visualize_field_action.ts

src/plugins/discover/public/application/components/sidebar/discover_field_details.tsx

x-pack/plugins/maps/public/kibana_services.ts

src/plugins/discover/public/application/components/sidebar/discover_field_details.tsx

kertal

Code LGTM 👍 it's much better this way, thx for this cleanup and improvement! Tested locally in Firefox, Chrome, Safari, also with a role with only Discover enabled. No regressions detected.

kibanamachine · 2020-08-19T08:34:31Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 63580ef
Flaky suites:
- oss-pluginFunctional

Test Failures

Plugin Functional Tests.test/plugin_functional/test_suites/core/route·ts.core route timeouts idle socket should timeout if servers response is too slow

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: core
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: route
[00:00:00]             └-> "before all" hook
[00:00:00]             └-: timeouts
[00:00:00]               └-> "before all" hook
[00:00:00]               └-: idle socket
[00:00:00]                 └-> "before all" hook
[00:00:00]                 └-> should timeout if payload sending has too long of an idle period
[00:00:00]                   └-> "before each" hook: global before each
[00:00:00]                   └- ✓ pass  (52ms) "core route timeouts idle socket should timeout if payload sending has too long of an idle period"
[00:00:00]                 └-> should not timeout if payload sending does not have too long of an idle period
[00:00:00]                   └-> "before each" hook: global before each
[00:00:00]                   └- ✓ pass  (223ms) "core route timeouts idle socket should not timeout if payload sending does not have too long of an idle period"
[00:00:00]                 └-> should timeout if servers response is too slow
[00:00:00]                   └-> "before each" hook: global before each
[00:00:00]                   │ info Taking screenshot "/dev/shm/workspace/parallel/3/kibana/test/functional/screenshots/failure/core route timeouts idle socket should timeout if servers response is too slow.png"
[00:00:01]                   │ info Current URL is: data:/,
[00:00:01]                   │ info Saving page source to: /dev/shm/workspace/parallel/3/kibana/test/plugin_functional/failure_debug/html/core route timeouts idle socket should timeout if servers response is too slow.html
[00:00:01]                   └- ✖ fail: core route timeouts idle socket should timeout if servers response is too slow
[00:00:01]                   │      Error: expected 'read ECONNRESET' to equal 'socket hang up'
[00:00:01]                   │       at Assertion.assert (packages/kbn-expect/expect.js:100:11)
[00:00:01]                   │       at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
[00:00:01]                   │       at Assertion.be (packages/kbn-expect/expect.js:69:22)
[00:00:01]                   │       at result.then.err (test/plugin_functional/test_suites/core/route.ts:147:38)
[00:00:01]                   │       at process._tickCallback (internal/process/next_tick.js:68:7)
[00:00:01]                   │ 
[00:00:01]                   │

Stack Trace

Error: expected 'read ECONNRESET' to equal 'socket hang up'
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at result.then.err (test/plugin_functional/test_suites/core/route.ts:147:38)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
discover	258	-7	265
maps	695	+2	693
uiActions	34	+2	32
visualize	315	+4	311
total		+1

async chunks size

id	value	diff	baseline
discover	430.7KB	-5.5KB	436.3KB
maps	3.3MB	-7.4KB	3.3MB
visualize	693.8KB	+1.0B	693.8KB
total		-12.9KB

page load bundle size

id	value	diff	baseline
discover	229.3KB	+373.0B	229.0KB
maps	296.4KB	+17.5KB	278.9KB
uiActions	218.6KB	+3.7KB	214.9KB
visualize	41.3KB	+10.3KB	31.0KB
total		+31.9KB

History

💚 Build #68751 succeeded c8fd6cc
💚 Build #68735 succeeded dfe1083
💚 Build #68669 succeeded 51bf61b
💚 Build #68660 succeeded 33777d0
💚 Build #68333 succeeded cdfb9fd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Navigate from discover to visualize with registering into a trigger * Implement the VISUALIZE_FIELD action * Implementation of the maps app trigger actions with the isCompatible functionality * clean up discover code and tile map action implementation * Add typeIsHidden on mocks * Retrieve filters and query from url state * functional test for oss and tile map * include geoshape * fix functional tests * fix types * remove unecessary dependencies * minor fixes * Remove tilemaps actios as it is going tobe deprecated * Add useEffect on discover details and move the map action to a separate folder * Retrieve map tooltips info from context * Retrieve query and filters from QueryService * Building urls with urlGenerators * replace with constants, fetch initialLayers as array * remove irrelevant comments * nice improvements * Return contextualFields for both triggers * Add getHref on actions, move capabilities to isCompatible method per action and other fixes * fix type * Fix type incompatibility after merging with master * fixes on maps plugin file after merge * remove unecessary declarations * nice improvements * Refactor maps services code to be inline with master Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Navigate from discover to visualize with registering into a trigger * Implement the VISUALIZE_FIELD action * Implementation of the maps app trigger actions with the isCompatible functionality * clean up discover code and tile map action implementation * Add typeIsHidden on mocks * Retrieve filters and query from url state * functional test for oss and tile map * include geoshape * fix functional tests * fix types * remove unecessary dependencies * minor fixes * Remove tilemaps actios as it is going tobe deprecated * Add useEffect on discover details and move the map action to a separate folder * Retrieve map tooltips info from context * Retrieve query and filters from QueryService * Building urls with urlGenerators * replace with constants, fetch initialLayers as array * remove irrelevant comments * nice improvements * Return contextualFields for both triggers * Add getHref on actions, move capabilities to isCompatible method per action and other fixes * fix type * Fix type incompatibility after merging with master * fixes on maps plugin file after merge * remove unecessary declarations * nice improvements * Refactor maps services code to be inline with master Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (112 commits) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) Fix docs in trigger alerting UI (elastic#75363) [SIEM] Fixes search bar Cypress test (elastic#74833) Add libnss3.so to Dockerfile template (reporting) (elastic#75370) [Discover] Create field_button and add popovers to sidebar (elastic#73226) [Reporting] Network Policy: Do not throw from the intercept handler (elastic#75105) [Reporting] Increase capture.timeouts.openUrl to 1 minute (elastic#75207) Allow routes to specify the idle socket timeout in addition to the payload timeout (elastic#73730) [src/dev/build] remove node-version from snapshots (elastic#75303) [ENDPOINT] Reintroduced tabs to endpoint management and migrated pages to use common security components (elastic#74886) [Canvas] Remove dependency on legacy expressions APIs (elastic#74885) Skip failing test in CI (elastic#75266) [Task Manager] time out work when it overruns in poller (elastic#74980) [Drilldowns] misc improvements & fixes (elastic#75276) Small README note on bumping memory for builds (elastic#75247) ...

* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...

stratoula added 12 commits July 30, 2020 11:21

Navigate from discover to visualize with registering into a trigger

9c95557

Implement the VISUALIZE_FIELD action

08fcf5b

Implementation of the maps app trigger actions with the isCompatible …

a3756ff

…functionality

clean up discover code and tile map action implementation

a590a5e

Add typeIsHidden on mocks

814d7cc

Merge with master

e87fa63

Retrieve filters and query from url state

baf82b0

functional test for oss and tile map

6ce6216

include geoshape

8c8b6b4

fix functional tests

b7ec202

fix types

aae1b6c

remove unecessary dependencies

8c56cf7

stratoula changed the title ~~Uiactions navigate to visualize~~ Uiactions navigate to visualize or maps Aug 4, 2020

stratoula changed the title ~~Uiactions navigate to visualize or maps~~ Uiactions to navigate to visualize or maps Aug 4, 2020

minor fixes

ffc0008

stratoula added Feature:Discover Discover Application Feature:Vis Editor Visualization editor issues 7.10.0 v8.0.0 release_note:enhancement labels Aug 4, 2020

stratoula marked this pull request as ready for review August 4, 2020 13:17

stratoula requested a review from a team August 4, 2020 13:17

stratoula requested review from a team as code owners August 4, 2020 13:17

stratoula added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Aug 4, 2020

stratoula requested review from flash1293, kertal and timroes August 4, 2020 13:17

stratoula removed the 7.10.0 label Aug 4, 2020

timroes reviewed Aug 13, 2020

View reviewed changes

src/plugins/discover/public/application/components/sidebar/lib/visualize_trigger_utils.ts Outdated Show resolved Hide resolved

Return contextualFields for both triggers

b1e27bb

timroes reviewed Aug 13, 2020

View reviewed changes

stratoula added 4 commits August 14, 2020 11:02

Add getHref on actions, move capabilities to isCompatible method per …

0f5b898

…action and other fixes

resolve conflicts

f7b691e

fix type

86bf980

Fix type incompatibility after merging with master

389fd4c

elasticmachine and others added 4 commits August 17, 2020 00:23

Merge branch 'master' into uiactions-navigate-to-visualize

cdfb9fd

changes on maps services after merging with master

bde9c73

fixes on maps plugin file after merge

33777d0

remove unecessary declarations

51bf61b

timroes reviewed Aug 18, 2020

View reviewed changes

kertal reviewed Aug 18, 2020

View reviewed changes

src/plugins/discover/public/application/components/sidebar/discover_field_details.tsx Show resolved Hide resolved

nice improvements

dfe1083

nreese reviewed Aug 18, 2020

View reviewed changes

x-pack/plugins/maps/public/kibana_services.ts Outdated Show resolved Hide resolved

Refactor maps services code to be inline with master

c8fd6cc

kertal reviewed Aug 18, 2020

View reviewed changes

src/plugins/discover/public/application/components/sidebar/discover_field_details.tsx Outdated Show resolved Hide resolved

resolve conflicts by merging from master

63580ef

kertal self-requested a review August 19, 2020 08:29

kertal approved these changes Aug 19, 2020

View reviewed changes

stratoula merged commit b6c4757 into elastic:master Aug 19, 2020

stratoula mentioned this pull request Aug 19, 2020

[7.x] Uiactions to navigate to visualize or maps (#74121) #75398

Merged

nreese mentioned this pull request Nov 18, 2020

Have maps use url generators and ui actions for discover -> maps drilldown. #61841

Closed

stratoula mentioned this pull request Jan 25, 2021

Remove navigation from Discover to Visualize #89132

Merged

Conversation

stratoula commented Aug 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Aug 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timroes Aug 13, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stratoula commented Aug 17, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 19, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

stratoula commented Aug 3, 2020 •

edited

Loading