Skip to content

[7.x] Uiactions to navigate to visualize or maps (#74121)#75398

Merged
stratoula merged 1 commit intoelastic:7.xfrom
stratoula:backport/7.x/pr-74121
Aug 19, 2020
Merged

[7.x] Uiactions to navigate to visualize or maps (#74121)#75398
stratoula merged 1 commit intoelastic:7.xfrom
stratoula:backport/7.x/pr-74121

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

* Navigate from discover to visualize with registering into a trigger

* Implement the VISUALIZE_FIELD action

* Implementation of the maps app trigger actions with the isCompatible functionality

* clean up discover code and tile map action implementation

* Add typeIsHidden on mocks

* Retrieve filters and query from url state

* functional test for oss and tile map

* include geoshape

* fix functional tests

* fix types

* remove unecessary dependencies

* minor fixes

* Remove tilemaps actios as it is going tobe deprecated

* Add useEffect on discover details and move the map action to a separate folder

* Retrieve map tooltips info from context

* Retrieve query and filters from QueryService

* Building urls with urlGenerators

* replace with constants, fetch initialLayers as array

* remove irrelevant comments

* nice improvements

* Return contextualFields for both triggers

* Add getHref on actions, move capabilities to isCompatible method per action and other fixes

* fix type

* Fix type incompatibility after merging with master

* fixes on maps plugin file after merge

* remove unecessary declarations

* nice improvements

* Refactor maps services code to be inline with master

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@stratoula stratoula added the backport This PR is a backport of another PR label Aug 19, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
discover 258 -7 265
maps 695 +2 693
uiActions 32 +2 30
visualize 315 +4 311
total +1

async chunks size

id value diff baseline
discover 430.7KB -5.5KB 436.3KB
maps 3.3MB -7.4KB 3.3MB
visualize 693.8KB +1.0B 693.8KB
total -12.9KB

page load bundle size

id value diff baseline
discover 229.3KB +373.0B 229.0KB
maps 296.4KB +17.5KB 278.9KB
uiActions 214.6KB +3.7KB 210.9KB
visualize 41.3KB +10.3KB 31.0KB
total +31.9KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit e3e352b into elastic:7.x Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants