[Visualize] Horizontal Bar Percentiles Overlapping#75315
Merged
alexwizp merged 4 commits intoelastic:masterfrom Aug 19, 2020
Merged
[Visualize] Horizontal Bar Percentiles Overlapping#75315alexwizp merged 4 commits intoelastic:masterfrom
alexwizp merged 4 commits intoelastic:masterfrom
Conversation
ThomThomson
approved these changes
Aug 18, 2020
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Tested in chrome 84, and this seems to fix the overlapping issue in both scenarios that I found it in.
Code changes LGTM!
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
nickofthyme
approved these changes
Aug 18, 2020
Contributor
nickofthyme
left a comment
There was a problem hiding this comment.
Code changes look good to me. We had a similar issue in elastic charts recently and fixed it in a similar way.
Verified issues are resolved on Chrome (shown below) and Firefox.
Case 1
Case 2
Also verified the vertical bar chart type is unaffected.
|
Can we add automated tests for this PR? We don't have anything that covers some of these visualizations options. Would be great if it doesn't have to be a UI Functional test. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Aug 19, 2020
* [Visualize] Horizontal Bar Percentiles Overlapping Closes: elastic#74986 * add tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 19, 2020
* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...
alexwizp
added a commit
that referenced
this pull request
Aug 19, 2020
* [Visualize] Horizontal Bar Percentiles Overlapping Closes: #74986 * add tests Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #74986
Summary
In 7.9, using the percentiles aggregation on a horizontal bar chart will result in all the percentiles bars being overlapped into the top bar.
Steps to reproduce:
Checklist
Delete any items that are not applicable to this PR.
For maintainers