[ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning by walterra · Pull Request #74499 · elastic/kibana

walterra · 2020-08-06T11:27:59Z

Summary

Refactors the action buttons for transforms and analytics job list to no longer produce nested button elements and throw a React error.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

peteharverson

Tested and confirmed the DOM errors are no longer seen. Just left a couple of minor comments.

peteharverson · 2020-08-17T15:44:43Z

...form/public/app/sections/transform_management/components/transform_list/use_actions.test.tsx

-    expect(typeof actions[2].render).toBe('function');
-    expect(typeof actions[3].render).toBe('function');
+    // Using `any` for the callback. Somehow the EUI types don't pass
+    // on the `data-test-subj` attribute correctly. We're interesting


Typo! Should be interested.

Fixed in 74071d9.

peteharverson · 2020-08-17T16:13:10Z

x-pack/plugins/ml/public/application/overview/components/analytics_panel/actions.tsx

+        color="text"
+        size="xs"
+        onClick={clickHandler}
+        iconType="tableOfContents"


I think we should switch this icon to be consistent with the one in the main DFA jobs list - tableDensityNormal.

Consolidated button icons in c9fc1b2.

alvarezmelissa87 · 2020-08-17T18:40:16Z

...data_frame_analytics/pages/analytics_management/components/action_start/use_start_action.tsx

+          canStartStopDataFrameAnalytics={canStartStopDataFrameAnalytics}
+        />
+      ),
+      available: (i: DataFrameAnalyticsListRow) => !isDataFrameAnalyticsRunning(i.stats.state),


I think there needs to be a check here for the job being in a failed state to ensure that we don't lose the fix from (https://github.com/elastic/kibana/pull/74710/files)

E.g. !isDataFrameAnalyticsFailed(i.stats.state).

Good catch! I carried over the changes related to the stop action rendering but missed this one. Fixed in c9fc1b2.

alvarezmelissa87 · 2020-08-17T18:43:41Z

...n/data_frame_analytics/pages/analytics_management/components/action_stop/use_stop_action.tsx

+  const action: DataFrameAnalyticsListAction = useMemo(
+    () => ({
+      name: () => <StopActionName isDisabled={!canStartStopDataFrameAnalytics} />,
+      available: (i: DataFrameAnalyticsListRow) => isDataFrameAnalyticsRunning(i.stats.state),


Similarly, there might need to be a check to allow force stop for jobs in a failed state.

Good catch! I carried over the changes related to the stop action rendering but missed this one. Fixed in c9fc1b2.

alvarezmelissa87 · 2020-08-17T19:08:30Z

Looks good overall. Gave it a test and looks good aside from the comments I left.

alvarezmelissa87

Latest changes LGTM ⚡

x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container.js

x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_actions/results.js

peteharverson

Latest edits LGTM

darnautov · 2020-08-19T09:01:19Z

...ata_frame_analytics/pages/analytics_management/components/action_clone/clone_action_name.tsx

 /**
 * Temp component to have Clone job button with the same look as the other actions.
 * Replace with {@link getCloneAction} as soon as all the actions are refactored
 * to support EuiContext with a valid DOM structure without nested buttons.
 */


we probably don't need this comment anymore

kibanamachine · 2020-08-19T13:29:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 274e106

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
ml	1357	+2	1355
transform	320	+2	318
total		+4

async chunks size

id	value	diff	baseline
ml	8.0MB	+4.1KB	8.0MB
transform	704.4KB	+3.8KB	700.6KB
total		+7.9KB

page load bundle size

id	value	diff	baseline
ml	573.5KB	+86.0B	573.4KB

History

💚 Build #68986 succeeded a54d94f
💚 Build #68698 succeeded f440ff5
💔 Build #68695 failed c9fc1b2
💚 Build #68395 succeeded ab1de2e
💔 Build #68377 failed e76996a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…nesting warning (elastic#74499) Refactors the action buttons for transforms and analytics job list to no longer produce nested button elements and throw a React error.

* master: (30 commits) [code coverage] always download node before team assignment (elastic#75424) [Form lib] Allow new "defaultValue" to be provided when resetting the… (elastic#75302) [Logs UI] Add "View in machine learning" links in the anomaly explorer (elastic#74555) skip flaky suite (elastic#75440) skip flaky suite (elastic#75386) [Saved objects] Add support for version on create & bulkCreate when overwriting a document (elastic#75172) [Functional]Table Vis increase sleep time in order filter to be applied (elastic#75138) MOAR RAM (elastic#75423) [Visualize] Horizontal Bar Percentiles Overlapping (elastic#75315) [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (elastic#74499) [ML] Inference models management (elastic#74978) [Monitoring] Migrate karma tests (elastic#75301) [Index template] Add filters to simulate preview (elastic#74497) Bump and consolidate dependencies (elastic#75360) [Ingest Manager] Fix agent config rollout rate limit to use constants (elastic#75364) Update Node.js to version 10.22.0 (elastic#75254) [ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (elastic#74953) [Discover] Fix histogram cloud tests (elastic#75268) Uiactions to navigate to visualize or maps (elastic#74121) Use prefix search invis editor field/agg combo box (elastic#75290) ...

…nesting warning (#74499) (#75436) Refactors the action buttons for transforms and analytics job list to no longer produce nested button elements and throw a React error.

thompsongl added 30 commits July 21, 2020 10:39

eui to 27.1.0

56f847d

eui to 27.2.0

6e88169

buttoniconside type

4d1fb82

euiselectable type

006b6fd

update onScroll callback and polyfill size references

1bb3fa0

findTestSubject ts

d97395c

buttoncontent and collapsiblenav src snapshot updates

9aa61d4

update prop retrieval

5ccbd18

xpack snapshots

810d4c1

jest updates

8cb46b5

Merge branch 'master' into eui/27

92e92e5

Merge branch 'master' into eui/27

e254e4c

type fixes

d91ca43

Merge branch 'master' into eui/27

5d20471

more snapshots

5bfcae2

Merge branch 'master' into eui/27

74ba69d

virtual list changes

b9ba0b1

more virtualization changes

a17cc17

Merge branch 'master' into eui/27

3912ad2

merge

2537aa9

Merge branch 'master' into eui/27

b1d6710

fix functional tests

79cc7fe

Merge branch 'master' into eui/27

9b644b2

Merge branch 'master' into eui/27

5b72e28

data-test-subj for indexPatter-switcher

2f84eed

Merge branch 'master' into eui/27

954e63c

storyshots

2791b0c

eui to 27.3.1

6b92ad9

Merge branch 'master' into eui/27

735fb2e

Merge branch 'master' into eui/27

c03ea3a

walterra requested review from alvarezmelissa87 and darnautov August 17, 2020 13:23

peteharverson reviewed Aug 17, 2020

View reviewed changes

alvarezmelissa87 reviewed Aug 17, 2020

View reviewed changes

walterra added 3 commits August 18, 2020 10:29

Merge branch 'master' into ml-fix-list-action-buttons-3

269c223

[ML] Fix comment typo.

74071d9

[ML] Consolidate button icons.

c9fc1b2

walterra requested review from alvarezmelissa87 and peteharverson August 18, 2020 10:16

walterra added 2 commits August 18, 2020 12:31

[ML] Fix imports and types.

3158d8d

[ML] Fix translations.

f440ff5

alvarezmelissa87 approved these changes Aug 18, 2020

View reviewed changes

peteharverson reviewed Aug 18, 2020

View reviewed changes

x-pack/plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container.js Show resolved Hide resolved

peteharverson reviewed Aug 18, 2020

View reviewed changes

x-pack/plugins/ml/public/application/jobs/jobs_list/components/job_actions/results.js Show resolved Hide resolved

[ML] Change icons for view-series and SMV-button to visLine.

a54d94f

walterra requested a review from peteharverson August 19, 2020 07:48

peteharverson approved these changes Aug 19, 2020

View reviewed changes

darnautov reviewed Aug 19, 2020

View reviewed changes

[ML] Remove obsolete comment.

274e106

walterra merged commit e61a4b6 into elastic:master Aug 19, 2020

walterra deleted the ml-fix-list-action-buttons-3 branch August 19, 2020 14:26

walterra mentioned this pull request Aug 19, 2020

[7.x] [ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (#74499) #75436

Merged

peteharverson mentioned this pull request Aug 24, 2020

[ML] Disable Overview view links for analytics jobs with no results #75740

Merged

2 tasks

walterra mentioned this pull request Sep 1, 2020

Transforms: Edit transforms flyout #67255

Open

12 tasks

Conversation

walterra commented Aug 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson Aug 17, 2020

Choose a reason for hiding this comment

Uh oh!

walterra Aug 18, 2020

Choose a reason for hiding this comment

Uh oh!

peteharverson Aug 17, 2020

Choose a reason for hiding this comment

Uh oh!

walterra Aug 18, 2020

Choose a reason for hiding this comment

Uh oh!

alvarezmelissa87 Aug 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walterra Aug 18, 2020

Choose a reason for hiding this comment

Uh oh!

alvarezmelissa87 Aug 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

walterra Aug 18, 2020

Choose a reason for hiding this comment

Uh oh!

alvarezmelissa87 commented Aug 17, 2020

Uh oh!

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

darnautov Aug 19, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 19, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

walterra commented Aug 6, 2020 •

edited

Loading

alvarezmelissa87 Aug 17, 2020 •

edited

Loading

alvarezmelissa87 Aug 17, 2020 •

edited

Loading