[Lens] Fix crash when two layers xychart switches to pie#75267
Merged
mbondyra merged 3 commits intoelastic:masterfrom Aug 18, 2020
Merged
[Lens] Fix crash when two layers xychart switches to pie#75267mbondyra merged 3 commits intoelastic:masterfrom
mbondyra merged 3 commits intoelastic:masterfrom
Conversation
…ers switching to pie chart
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
commented
Aug 18, 2020
| : undefined; | ||
|
|
||
| return { suggestions: newSuggestions, currentStateExpression: newStateExpression }; | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
Contributor
Author
There was a problem hiding this comment.
this is the main change.
mbondyra
commented
Aug 18, 2020
59 tasks
flash1293
approved these changes
Aug 18, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested and not getting any crashes, LGTM. Thanks for adding a test as well, this was definitely necessary.
I think we can revisit this later, maybe by memoizing the relevant parts of the frame API itself. If you merge this, could you make sure #74090 is up to date?
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Aug 18, 2020
* [Lens] fix crash on two layers and add a functional test with two layers switching to pie chart
mbondyra
added a commit
that referenced
this pull request
Aug 18, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 18, 2020
* master: Skip failing test in CI (elastic#75266) [Task Manager] time out work when it overruns in poller (elastic#74980) [Drilldowns] misc improvements & fixes (elastic#75276) Small README note on bumping memory for builds (elastic#75247) [Security Solution][Detections] Adds exception modal tests (elastic#74596) [Dashboard] Sample data link does not work (elastic#75262) [Dashboard First] Unlink from Library Action With ReferenceOrValueEmbeddable (elastic#74905) [Form lib] Fix issue where serializer on fields are called on every change (elastic#75166) convert processor labels to sentence case (elastic#75278) [Monaco] Refactor the way XJSON grammar checker gets registered (elastic#75160) Clarify no documents error message when filtering by is_training (elastic#75227) [Lens] Fix crash when two layers xychart switches to pie (elastic#75267) [Observability Homepage] Fix console error because of side effect (elastic#75258) [Usage Collection] Add `legacy=true` option to the /api/stats request in the docs (elastic#75146) [ML] Functional tests - re-activate DFA test suites (elastic#75257) GS providers improvements (elastic#75174) [Visualize] First version of by-value visualize editor (elastic#72256)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 19, 2020
…emove-header * saved-objects/version-on-create: (59 commits) remove version when loading sample data omit version from SO import/export Skip failing test in CI (elastic#75266) [Task Manager] time out work when it overruns in poller (elastic#74980) [Drilldowns] misc improvements & fixes (elastic#75276) Small README note on bumping memory for builds (elastic#75247) [Security Solution][Detections] Adds exception modal tests (elastic#74596) Revert "Revert "added missing core docs"" Revert "Revert "added version to saved object bulk creation"" [Dashboard] Sample data link does not work (elastic#75262) [Dashboard First] Unlink from Library Action With ReferenceOrValueEmbeddable (elastic#74905) [Form lib] Fix issue where serializer on fields are called on every change (elastic#75166) convert processor labels to sentence case (elastic#75278) [Monaco] Refactor the way XJSON grammar checker gets registered (elastic#75160) Clarify no documents error message when filtering by is_training (elastic#75227) [Lens] Fix crash when two layers xychart switches to pie (elastic#75267) [Observability Homepage] Fix console error because of side effect (elastic#75258) [Usage Collection] Add `legacy=true` option to the /api/stats request in the docs (elastic#75146) [ML] Functional tests - re-activate DFA test suites (elastic#75257) GS providers improvements (elastic#75174) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #74841
The bug was introduced by adding
framedependency touseMemoin suggestionPanel. For now I just reverted the change here and also added a functional test to catch this behaviour in the future.