Skip to content

[ML] Functional tests - re-activate DFA test suites#75257

Merged
pheyos merged 1 commit intoelastic:masterfrom
pheyos:activate_dfa_tests
Aug 18, 2020
Merged

[ML] Functional tests - re-activate DFA test suites#75257
pheyos merged 1 commit intoelastic:masterfrom
pheyos:activate_dfa_tests

Conversation

@pheyos
Copy link
Copy Markdown
Member

@pheyos pheyos commented Aug 18, 2020

Summary

This PR re-enables the DFA test suites for cloning, regression creation and classification creation.

Additional details

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 18, 2020
@pheyos pheyos self-assigned this Aug 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 18, 2020

Pinging @elastic/ml-ui (:ml)

@pheyos
Copy link
Copy Markdown
Member Author

pheyos commented Aug 18, 2020 •
edited
Loading

Checking test stability in a flaky test runner job ... => no failure in 50 runs ✔️

walterra
walterra approved these changes Aug 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 18, 2020

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit 834a287 into elastic:master Aug 18, 2020
@pheyos pheyos deleted the activate_dfa_tests branch August 18, 2020 10:32
@pheyos
Copy link
Copy Markdown
Member Author

pheyos commented Aug 18, 2020

Backport needs to wait until elastic/elasticsearch/pull/59725 and the corresponding ml-cpp change are backported and contained in a promoted ES snapshot.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 18, 2020
@gmmorris
Merge branch 'master' into saved-objects/version-on-create
4dfcf10 
* master:
  Skip failing test in CI (elastic#75266)
  [Task Manager] time out work when it overruns in poller (elastic#74980)
  [Drilldowns] misc improvements & fixes (elastic#75276)
  Small README note on bumping memory for builds (elastic#75247)
  [Security Solution][Detections] Adds exception modal tests (elastic#74596)
  [Dashboard] Sample data link does not work (elastic#75262)
  [Dashboard First] Unlink from Library Action With ReferenceOrValueEmbeddable (elastic#74905)
  [Form lib] Fix issue where serializer on fields are called on every change (elastic#75166)
  convert processor labels to sentence case (elastic#75278)
  [Monaco] Refactor the way XJSON grammar checker gets registered (elastic#75160)
  Clarify no documents error message when filtering by is_training (elastic#75227)
  [Lens] Fix crash when two layers xychart  switches to pie (elastic#75267)
  [Observability Homepage] Fix console error because of side effect (elastic#75258)
  [Usage Collection] Add `legacy=true` option to the /api/stats request in the docs (elastic#75146)
  [ML] Functional tests - re-activate DFA test suites (elastic#75257)
  GS providers improvements (elastic#75174)
  [Visualize] First version of by-value visualize editor (elastic#72256)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 19, 2020
@gmmorris
Merge branch 'saved-objects/version-on-create' into actions/webhook-r…
78cb2cf 
…emove-header

* saved-objects/version-on-create: (59 commits)
  remove version when loading sample data
  omit version from SO import/export
  Skip failing test in CI (elastic#75266)
  [Task Manager] time out work when it overruns in poller (elastic#74980)
  [Drilldowns] misc improvements & fixes (elastic#75276)
  Small README note on bumping memory for builds (elastic#75247)
  [Security Solution][Detections] Adds exception modal tests (elastic#74596)
  Revert "Revert "added missing core docs""
  Revert "Revert "added version to saved object bulk creation""
  [Dashboard] Sample data link does not work (elastic#75262)
  [Dashboard First] Unlink from Library Action With ReferenceOrValueEmbeddable (elastic#74905)
  [Form lib] Fix issue where serializer on fields are called on every change (elastic#75166)
  convert processor labels to sentence case (elastic#75278)
  [Monaco] Refactor the way XJSON grammar checker gets registered (elastic#75160)
  Clarify no documents error message when filtering by is_training (elastic#75227)
  [Lens] Fix crash when two layers xychart  switches to pie (elastic#75267)
  [Observability Homepage] Fix console error because of side effect (elastic#75258)
  [Usage Collection] Add `legacy=true` option to the /api/stats request in the docs (elastic#75146)
  [ML] Functional tests - re-activate DFA test suites (elastic#75257)
  GS providers improvements (elastic#75174)
  ...
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 19, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75257 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 19, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 20, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75257 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 21, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75257 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 24, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75257 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 25, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 75257 or prevent reminders by adding the backport:skip label.

@pheyos pheyos mentioned this pull request Aug 26, 2020
Merged
pheyos added a commit to pheyos/kibana that referenced this pull request Aug 26, 2020
@pheyos
[ML] Functional tests - re-activate DFA test suites (elastic#75257)
479a68e 
This PR re-enables the DFA test suites for cloning, regression creation and classification creation.
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 26, 2020

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

pheyos added a commit that referenced this pull request Aug 27, 2020
@pheyos
[ML] Functional tests - re-activate DFA test suites (#75257) (#75948)
f19ef6c 
This PR re-enables the DFA test suites for cloning, regression creation and classification creation.
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 27, 2020
@pheyos pheyos mentioned this pull request Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@darnautov darnautov Awaiting requested review from darnautov

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@pheyos pheyos

Labels

:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pheyos @elasticmachine @kibanamachine @walterra