[ML] handle new model metadata stream from native process#59725
[ML] handle new model metadata stream from native process#59725davidkyle merged 8 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/ml-core (:ml) |
| "version" : ${xpack.ml.version.id}, | ||
| "index_patterns" : [ | ||
| ".ml-inference-000002" | ||
| ".ml-inference-000003" |
There was a problem hiding this comment.
Are these templates automatically installed when any new node comes online? Or does the new node have to be a master node?
@dimitris-athanasiou do you know?
There was a problem hiding this comment.
Aside of the question, I believe the index pattern here should be .ml-inference-* and we shouldn't have to change this each time.
Back to the question, all nodes get the templates installed regardless of whether they're master or not.
There was a problem hiding this comment.
@dimitris-athanasiou I am not sure. What if an older node has a specific mapping in mind and tries to write to the index?
A new index would be created with the new mapping (if it didn't already exist) and the new node does not have code to support the new mapping.
Keeping it versioned allows only NEW nodes to reference the new index mapping.
There was a problem hiding this comment.
I see, it makes sense.
|
The test failures are
model_id is missing from the mappings in the template |
davidkyle
left a comment
There was a problem hiding this comment.
Looks good, no comments just the test failures to fix
|
run elasticsearch-ci/2 |
|
run elasticsearch-ci/2 |
This adds the serialization handling for the new model_metadata object from the native process.
Right now, this document only stores total_feature_importance information.
It is also not yet currently consumed by any user consumed API.
relates: elastic/ml-cpp#1387