Fix more broken usages of bulkCreate#76005
Merged
jportner merged 5 commits intoelastic:masterfrom Aug 27, 2020
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
jgowdyelastic
approved these changes
Aug 26, 2020
Member
jgowdyelastic
left a comment
There was a problem hiding this comment.
ML changes tested, LGTM
Contributor
Author
|
Can someone from @elastic/kibana-core-ui review the changes to |
myasonik
approved these changes
Aug 27, 2020
src/plugins/home/public/application/components/tutorial/saved_objects_installer.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Aug 27, 2020
jportner
added a commit
to jportner/kibana
that referenced
this pull request
Aug 27, 2020
jportner
added a commit
that referenced
this pull request
Aug 28, 2020
jportner
added a commit
that referenced
this pull request
Aug 28, 2020
mikecote
added a commit
that referenced
this pull request
Aug 31, 2020
…writing a document (#76280) * Revert "Fix more broken usages of `bulkCreate` (#76005) (#76131)" This reverts commit 44a017b. * Revert "Filter saved object `version` during legacy import (#75597) (#75793)" This reverts commit 6e82885. * Revert "[7.9] [Saved objects] Add support for version on create & bulkCreate when overwriting a document (#75172) (#75498)" This reverts commit 00836e5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-on to #75597; that had to be merged first to verify that the fix worked as expected.
This PR addresses another broken usage of
bulkCreate(#75597 (comment)), and cleans up a type definition that is used when generatingbulkCreateargs (#75597 (comment)).