Skip to content

[main] Source code updates from dotnet/runtime#3024

Merged
ViktorHofer merged 11 commits intomainfrom
darc-main-b9dcf5cc-5d76-4432-84e4-a16b775f76f8
Oct 23, 2025
Merged

[main] Source code updates from dotnet/runtime#3024
ViktorHofer merged 11 commits intomainfrom
darc-main-b9dcf5cc-5d76-4432-84e4-a16b775f76f8

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Oct 21, 2025

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/runtime

@dotnet-maestro dotnet-maestro bot requested review from a team as code owners October 21, 2025 17:45
@dotnet-maestro
Copy link
Contributor Author

Note

PRs from original repository included in this codeflow update:

In case of unclarities, consult the FAQ or tag @dotnet/product-construction for assistance.

@jkoritzinsky
Copy link
Member

cc @kotlarmilos for the iOS failure.

@kotlarmilos
Copy link
Member

cc @kotlarmilos for the iOS failure.

This should be fixed in dotnet/runtime#120812.

@akoeplinger
Copy link
Member

akoeplinger commented Oct 22, 2025

@jkoritzinsky @max-charlamb the source-build failure looks like due to dotnet/runtime#120851

/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Microsoft.Diagnostics.DataContractReader.Abstractions.csproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.DotNet.ILCompiler (= 10.0.0-ci)' for 'net10.0'. PackageSourceMapping is enabled, the following source(s) were not considered: /__w/1/s/.dotnet/library-packs, prebuilt, previously-source-built, reference-packages, source-built-command-line-api, source-built-source-build-reference-packages, source-built-transport-arcade, source-built-transport-cecil. [/__w/1/s/src/runtime/Build.proj]
/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader/Microsoft.Diagnostics.DataContractReader.csproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.DotNet.ILCompiler (= 10.0.0-ci)' for 'net10.0'. PackageSourceMapping is enabled, the following source(s) were not considered: /__w/1/s/.dotnet/library-packs, prebuilt, previously-source-built, reference-packages, source-built-command-line-api, source-built-source-build-reference-packages, source-built-transport-arcade, source-built-transport-cecil. [/__w/1/s/src/runtime/Build.proj]
/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj : error NU1100: Unable to resolve 'runtime.linux-x64.Microsoft.DotNet.ILCompiler (= 10.0.0-ci)' for 'net10.0'. PackageSourceMapping is enabled, the following source(s) were not considered: /__w/1/s/.dotnet/library-packs, prebuilt, previously-source-built, reference-packages, source-built-command-line-api, source-built-source-build-reference-packages, source-built-transport-arcade, source-built-transport-cecil. [/__w/1/s/src/runtime/Build.proj]

@jkoritzinsky
Copy link
Member

I'll push a change to not pack those packages on Source-Build (we shouldn't need it there and that's in line with the mscordaccore_universal project).

@am11
Copy link
Member

am11 commented Oct 23, 2025

I'll push a change to not pack those packages on Source-Build (we shouldn't need it there and that's in line with the mscordaccore_universal project).

For crossgen2 and ilcompiler, it was handled by inbuilt/published variants. Can we bring cDAC to the same plan?

1 similar comment
@am11
Copy link
Member

am11 commented Oct 23, 2025

Ready to merge. (not sure why auto-merge failed 👀)

@ViktorHofer
Copy link
Member

Ready to merge. (not sure why auto-merge failed 👀)

Every PR needs an approval from someone with write access.

@ViktorHofer ViktorHofer merged commit c636320 into main Oct 23, 2025
16 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-b9dcf5cc-5d76-4432-84e4-a16b775f76f8 branch October 23, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants