Use UnsafeAccessor in System.Diagnostics.Debug.Tests#120732
Merged
jkoritzinsky merged 6 commits intodotnet:mainfrom Oct 17, 2025
Merged
Use UnsafeAccessor in System.Diagnostics.Debug.Tests#120732jkoritzinsky merged 6 commits intodotnet:mainfrom
jkoritzinsky merged 6 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the System.Diagnostics.Debug.Tests by replacing reflection-based access to internal Debug and DebugProvider members with the more efficient and type-safe UnsafeAccessor pattern. This addresses issue #120722 and follows modern .NET best practices for accessing private/internal members in tests.
Key changes:
- Replaces reflection calls with UnsafeAccessor methods for accessing internal Debug provider functionality
- Adds a new public GetProvider() method to Debug class to support testing needs
- Updates compatibility suppressions to handle the new public API
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/DebugTests.cs | Replaces reflection-based field access with UnsafeAccessor methods for cleaner, more efficient test code |
| src/libraries/System.Private.CoreLib/src/System/Diagnostics/Debug.cs | Adds public GetProvider() method to expose the internal provider for testing |
| src/libraries/System.Private.CoreLib/ref/System.Private.CoreLib.ExtraApis.txt | Registers the new GetProvider method in the extra APIs list |
| src/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml | Adds compatibility suppression for the new GetProvider method |
src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/DebugTests.cs
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/DebugTests.cs
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/DebugTests.cs
Show resolved
Hide resolved
src/libraries/System.Runtime/tests/System.Diagnostics.Debug.Tests/DebugTests.cs
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
jkotas
reviewed
Oct 15, 2025
src/coreclr/System.Private.CoreLib/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
Member
|
Cleanup this as well ? |
jkotas
reviewed
Oct 15, 2025
...es/System.Runtime/tests/System.Diagnostics.Debug.Tests/System.Diagnostics.Debug.Tests.csproj
Show resolved
Hide resolved
jkotas
approved these changes
Oct 16, 2025
noahfalk
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120722