Fix ArgumentException parameter name in ArrayBufferWriter#120880
Merged
stephentoub merged 3 commits intomainfrom Oct 20, 2025
Merged
Fix ArgumentException parameter name in ArrayBufferWriter#120880stephentoub merged 3 commits intomainfrom
stephentoub merged 3 commits intomainfrom
Conversation
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ArgumentException message in ArrayBufferWriter
Fix ArgumentException parameter name in ArrayBufferWriter
Oct 19, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in ArrayBufferWriter<T> where GetSpan() and GetMemory() methods were throwing ArgumentException with incorrect properties when passed a negative sizeHint parameter.
- Changes the
ArgumentExceptionconstructor call to properly set the parameter name - Enhances existing tests to verify the
ParamNameproperty is correctly set
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/Common/src/System/Buffers/ArrayBufferWriter.cs | Fixed ArgumentException constructor to use proper overload that sets ParamName correctly |
| src/libraries/System.Memory/tests/ArrayBufferWriter/ArrayBufferWriterTests.T.cs | Enhanced test to verify ParamName property is set to "sizeHint" for both GetSpan and GetMemory methods |
stephentoub
reviewed
Oct 19, 2025
src/libraries/System.Memory/tests/ArrayBufferWriter/ArrayBufferWriterTests.T.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
stephentoub
approved these changes
Oct 19, 2025
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
eiriktsarpalis
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the
ArgumentExceptionthrown byArrayBufferWriter<T>whenGetSpan()orGetMemory()is called with a negativesizeHint.Problem: The exception was incorrectly constructed, causing the parameter name to appear in the
Messageproperty instead of theParamNameproperty.Solution: Changed
throw new ArgumentException(nameof(sizeHint))tothrow new ArgumentException(null, nameof(sizeHint))inCheckAndResizeBuffer()method.Testing: Updated the
InvalidGetMemoryAndSpan()test to useAssertExtensions.Throwswhich verifies both the exception type and theParamNameproperty.Security Summary
No security vulnerabilities were discovered or introduced by these changes.
Original prompt
Fixes #120878
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.