[browser] build browserhost in clr.runtime subset#120666
Merged
pavelsavara merged 23 commits intodotnet:mainfrom Oct 15, 2025
Merged
[browser] build browserhost in clr.runtime subset#120666pavelsavara merged 23 commits intodotnet:mainfrom
pavelsavara merged 23 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the browser build system for CoreCLR runtime to integrate browserhost build into the clr.runtime subset. The key changes consolidate browser-specific assets into a shared framework directory and streamline the CMake build configuration.
Key changes:
- Consolidate JavaScript/TypeScript build logic into a common CMakeLists.txt file
- Split browserhost into static library (libBrowserHost.a) for customer linking
- Install browser runtime assets to sharedFramework directory for consumption
Reviewed Changes
Copilot reviewed 35 out of 37 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/native/rollup.config.js | Updates output paths to use staticLibDestination variable |
| src/native/rollup.config.defines.js | Adds staticLibDestination export and normalizes configuration values |
| src/native/libs/build-native.proj | Refactors native build arguments and removes hardcoded ICU/TZD paths |
| src/native/libs/Common/JavaScript/CMakeLists.txt | New consolidated CMake file for JavaScript build logic |
| src/native/libs/System.Native.Browser/CMakeLists.txt | Removes rollup build logic, delegates to Common/JavaScript |
| src/native/corehost/browserhost/host/CMakeLists.txt | New CMake file for static browserhost library |
| src/native/corehost/browserhost/CMakeLists.txt | Refactors to use static library and updated paths |
| src/coreclr/CMakeLists.txt | Updates WASM build configuration and paths |
| eng/native.props | New shared properties file for native build configuration |
| eng/liveBuilds.targets | Updates CoreCLR browser runtime file paths |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
radekdoulik
reviewed
Oct 14, 2025
radekdoulik
reviewed
Oct 14, 2025
radekdoulik
approved these changes
Oct 14, 2025
Member
radekdoulik
left a comment
There was a problem hiding this comment.
LGTM in general, lets wait for @jkoritzinsky's review
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
This was referenced Oct 15, 2025
jkoritzinsky
approved these changes
Oct 15, 2025
Member
jkoritzinsky
left a comment
There was a problem hiding this comment.
One last comment, otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is version B)
eng/native.propscorehost/build.cmdSTATIC_LIB_DESTINATIONand move all JS outputs thereSystem.Native.Browser-RollupandSystem.Native.Browser-NpmInstallinto it's ownCommon\JavaScript\CMakeLists.txtbrowserhostintolibBrowserHost.a, so that it could be linked later on customer machinesharedFrameworklibcoreclr_static,libclrinterpreter,libgcinfo_unix_wasm,libcoreclrminipal,libnativeresourcestring,libcoreclrpallibSystem.Native,libSystem.Native.TimeZoneData,libSystem.Native.TimeZoneData.Invariant,libSystem.Globalization.Native,libicuuc,libicui18n,libicudatalibSystem.IO.Compression.Native,libzlibSystem.Native.Browser,libSystem.Runtime.InteropServices.JavaScriptlibBrowserHost,dotnet.js,dotnet.runtime.jsminipaleng/liveBuilds.targetsto consume it from$(CoreCLRSharedFrameworkDir)Fixes #120188