Skip to content

Call fflush for each item in JitDisasmSummary#120458

Merged
EgorBo merged 1 commit intodotnet:mainfrom
EgorBo:add-fflush-jitdisasmsummary
Oct 15, 2025
Merged

Call fflush for each item in JitDisasmSummary#120458
EgorBo merged 1 commit intodotnet:mainfrom
EgorBo:add-fflush-jitdisasmsummary

Conversation

@EgorBo
Copy link
Member

@EgorBo EgorBo commented Oct 7, 2025

cc @AndyAyersMS who asked for it

Copilot AI review requested due to automatic review settings October 7, 2025 00:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an fflush() call to ensure immediate output of JIT disassembly summary messages. The change forces the output buffer to be flushed after each compiled method is logged, providing more reliable debugging output for JIT analysis.

Key changes:

  • Added fflush(jitstdout()) after each JIT compilation summary message

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 7, 2025
@EgorBo EgorBo requested a review from a team October 7, 2025 00:07
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, somewhere there's comment that printf(""); does the same thing. Not sure if it's still true though.

@EgorBo
Copy link
Member Author

EgorBo commented Oct 7, 2025

FYI, somewhere there's comment that printf(""); does the same thing. Not sure if it's still true though.

I actually copied this fflush(jitstdout()) from the JitDisasm routine.

@EgorBo EgorBo merged commit 6030faa into dotnet:main Oct 15, 2025
113 checks passed
@EgorBo EgorBo deleted the add-fflush-jitdisasmsummary branch October 15, 2025 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants