Remove dead code PathFeatures.cs and assume all path features are available by Copilot · Pull Request #120929 · dotnet/runtime

Copilot · 2025-10-21T03:23:48Z

Summary

Successfully removed PathFeatures.cs dead code and all its references. Replaced all conditional test attributes that depended on always-true properties with unconditional Fact/Theory attributes. Removed redundant property wrappers and merged duplicate test methods. Fixed ConditionalFact attributes to properly reference RemoteExecutor.IsSupported. All tests now assume:

All long paths are available (no legacy MAX_PATH limitations)
New path normalization is always used (no legacy path handling)
No conditional behavior based on runtime capabilities

Original prompt

This section details on the original issue you should resolve

<issue_title>PathFeatures.cs is dead code</issue_title>
<issue_description>PathFeatures.cs is only used in tests in target current netcoreapp app. All path features are available in current netcoreapp.</issue_description>

<agent_instructions>Please delete PathFeatures.cs and all references to it. Assume that all Path features are available and no legacy behaviors are present.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

Fixes #120928

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas

@copilot

src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.Windows.cs

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileSystemTest.cs

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

src/libraries/System.IO.Compression/tests/ZipArchive/zip_ManualAndCompatibilityTests.cs

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Delete.cs

...ibraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/IO/PathTests_Windows.cs

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

davidfowl · 2025-10-21T05:58:36Z

oops, ran the workflow on the wrong PR 😄

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot

Pull Request Overview

This PR removes the obsolete PathFeatures.cs file and all references to it throughout the codebase. The PathFeatures class was only used in tests targeting current netcoreapp where all path features (long paths, new normalization) are already available. The changes eliminate dead code and conditional logic that assumed legacy path behaviors.

Key changes:

Deleted PathFeatures.cs and removed its references from 5 csproj files
Replaced conditional test attributes (ConditionalFact/ConditionalTheory) with unconditional Fact/Theory attributes where they depended on always-true path feature checks
Removed conditional runtime logic that branched based on path normalization capabilities
Merged duplicate test methods that previously existed to handle legacy vs. new path normalization

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
PathFeatures.cs	Deleted obsolete file containing runtime path feature detection
System.Runtime.Extensions.Tests.csproj	Removed PathFeatures.cs reference
System.IO.FileSystem.Tests.csproj	Removed PathFeatures.cs reference
System.IO.FileSystem.DisabledFileLocking.Tests.csproj	Removed PathFeatures.cs reference
System.IO.Compression.Tests.csproj	Removed PathFeatures.cs reference
System.Diagnostics.Process.Tests.csproj	Removed PathFeatures.cs reference
PathTests_Windows.cs	Removed conditional logic based on legacy path normalization and merged duplicate test cases
PathTestsBase.cs	Updated test data to use non-legacy expected values
FileSystemTest.cs	Removed property wrappers for PathFeatures methods
Delete.cs	Replaced redundant property wrappers with direct RemoteExecutor.IsSupported checks
zip_ManualAndCompatibilityTests.cs	Removed PathFeatures usage and converted conditional test to unconditional
ProcessModuleTests.Windows.cs	Converted ConditionalFact to Fact and updated comment
Various test files	Converted ConditionalFact/ConditionalTheory to Fact/Theory

dotnet-policy-service · 2025-10-21T06:58:49Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

adamsitnik

@copilot please apply my suggestions to fix following CI failure:

[FAIL] System.IO.Tests.Directory_Delete_str_bool.ExtendedDirectoryWithSubdirectories
System.InvalidOperationException : An appropriate member 'IsSupported' could not be found. The conditional method needs to be a static method, property, or field on the type System.IO.Tests.Directory_Delete_str or any ancestor, of any visibility, accepting zero arguments, and having a return type of Boolean.

[FAIL] System.IO.Tests.Directory_Delete_str_bool.LongPathExtendedDirectory
System.InvalidOperationException : An appropriate member 'IsSupported' could not be found. The conditional method needs to be a static method, property, or field on the type System.IO.Tests.Directory_Delete_str or any ancestor, of any visibility, accepting zero arguments, and having a return type of Boolean.

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Delete.cs

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot · 2025-10-21T08:13:57Z

@copilot please apply my suggestions to fix following CI failure:

...

Applied the suggested fixes to add typeof(RemoteExecutor) parameter to both ConditionalFact attributes. (commit 6c4e3a5)

Initial plan

b9ca0a9

Copilot AI assigned Copilot and jkotas Oct 21, 2025

Copilot started work on behalf of jkotas October 21, 2025 03:24 View session

github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 21, 2025

Remove PathFeatures.cs and all references

42c6c67

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas reviewed Oct 21, 2025

View reviewed changes

src/libraries/System.Diagnostics.Process/tests/ProcessModuleTests.Windows.cs Show resolved Hide resolved

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/FileSystemTest.cs Outdated Show resolved Hide resolved

Copilot AI changed the title ~~[WIP] Remove PathFeatures.cs and its references~~ Remove dead code PathFeatures.cs and assume all path features are available Oct 21, 2025

Copilot finished work on behalf of jkotas October 21, 2025 04:07

Copilot AI requested a review from jkotas October 21, 2025 04:07

Copilot started work on behalf of jkotas October 21, 2025 04:07 View session

Address feedback: remove always-true properties and update comment

be36e52

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot finished work on behalf of jkotas October 21, 2025 04:36

jkotas reviewed Oct 21, 2025

View reviewed changes

src/libraries/System.IO.Compression/tests/ZipArchive/zip_ManualAndCompatibilityTests.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of jkotas October 21, 2025 05:22 View session

jkotas reviewed Oct 21, 2025

View reviewed changes

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Delete.cs Outdated Show resolved Hide resolved

jkotas reviewed Oct 21, 2025

View reviewed changes

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Delete.cs Outdated Show resolved Hide resolved

jkotas reviewed Oct 21, 2025

View reviewed changes

...ibraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/IO/PathTests_Windows.cs Outdated Show resolved Hide resolved

Remove always-true IsUsingNewPathNormalization property

ae329ca

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot finished work on behalf of jkotas October 21, 2025 05:42

Copilot AI requested a review from jkotas October 21, 2025 05:42

Copilot started work on behalf of jkotas October 21, 2025 05:42 View session

Remove redundant property wrappers and merge test cases

f2529bc

Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot finished work on behalf of jkotas October 21, 2025 06:12

jkotas approved these changes Oct 21, 2025

View reviewed changes

jkotas marked this pull request as ready for review October 21, 2025 06:57

jkotas requested review from Copilot and stephentoub October 21, 2025 06:57

jkotas added the area-System.IO label Oct 21, 2025

jkotas removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 21, 2025

Copilot AI reviewed Oct 21, 2025

View reviewed changes

adamsitnik reviewed Oct 21, 2025

View reviewed changes

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Delete.cs Outdated Show resolved Hide resolved

src/libraries/System.Runtime/tests/System.IO.FileSystem.Tests/Directory/Delete.cs Outdated Show resolved Hide resolved

Copilot started work on behalf of adamsitnik October 21, 2025 07:52 View session

Fix ConditionalFact attributes to include type parameter

aaa19f8

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Copilot AI requested a review from adamsitnik October 21, 2025 08:14

Copilot finished work on behalf of adamsitnik October 21, 2025 08:14

stephentoub approved these changes Oct 21, 2025

View reviewed changes

stephentoub merged commit 9bb1d21 into main Oct 21, 2025
84 checks passed

stephentoub deleted the copilot/remove-dead-code-pathfeatures branch October 21, 2025 10:44

dotnet-maestro bot mentioned this pull request Oct 21, 2025

[main] Source code updates from dotnet/runtime dotnet/dotnet#3024

Merged

github-actions bot locked and limited conversation to collaborators Nov 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dead code PathFeatures.cs and assume all path features are available#120929

Remove dead code PathFeatures.cs and assume all path features are available#120929
stephentoub merged 6 commits intomainfrom
copilot/remove-dead-code-pathfeatures

Copilot AI commented Oct 21, 2025 •

edited

Loading

Uh oh!

jkotas left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidfowl commented Oct 21, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

dotnet-policy-service bot commented Oct 21, 2025

Uh oh!

adamsitnik left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

Copilot AI commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Comments on the Issue (you are @copilot in this section)

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidfowl commented Oct 21, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dotnet-policy-service bot commented Oct 21, 2025

Uh oh!

adamsitnik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Copilot AI commented Oct 21, 2025 •

edited

Loading