Remove dead code PathFeatures.cs and assume all path features are available (#120929) - [x] Delete PathFeatures.cs file - [x] Remove PathFeatures.cs references from .csproj files (5 files) - [x] Update FileSystemTest.cs to remove PathFeatures usage (3 properties) - [x] Update PathTestsBase.cs to use non-legacy values in TestData_GetPathRoot_DevicePaths (5 lines) - [x] Update PathTests_Windows.cs to remove conditional logic based on PathFeatures (9 usages) - [x] Update zip_ManualAndCompatibilityTests.cs to remove PathFeatures usage (1 property + 1 conditional) - [x] Update ProcessModuleTests.Windows.cs to remove ConditionalFact attribute (1 line) - [x] Build and test affected libraries to ensure all tests pass - System.Runtime.Extensions.Tests: 8280 tests passed - System.IO.FileSystem.Tests: 8716 tests passed - System.IO.Compression.Tests: 1335 tests passed - System.Diagnostics.Process.Tests: 339 tests passed - [x] Run final verification of all changes - [x] Address feedback: Remove AreAllLongPathsAvailable, LongPathsAreNotBlocked, and UsingNewNormalization properties - [x] Address feedback: Update outdated comment about ConditionalFact in ProcessModuleTests.Windows.cs - [x] Address feedback: Remove IsUsingNewPathNormalization property from zip_ManualAndCompatibilityTests.cs - [x] Address feedback: Remove redundant property wrappers in Delete.cs and replace with RemoteExecutor.IsSupported - [x] Address feedback: Merge GetFullPath_Windows_UNC_Valid_LegacyPathSupport test cases into GetFullPath_UNC_Valid - [x] Fix CI failure: Add typeof(RemoteExecutor) parameter to ConditionalFact attributes ## Summary Successfully removed PathFeatures.cs dead code and all its references. Replaced all conditional test attributes that depended on always-true properties with unconditional Fact/Theory attributes. Removed redundant property wrappers and merged duplicate test methods. Fixed ConditionalFact attributes to properly reference RemoteExecutor.IsSupported. All tests now assume: - All long paths are available (no legacy MAX_PATH limitations) - New path normalization is always used (no legacy path handling) - No conditional behavior based on runtime capabilities

Original prompt

> > ---- > > *This section details on the original issue you should resolve* > > PathFeatures.cs is dead code > PathFeatures.cs is only used in tests in target current netcoreapp app. All path features are available in current netcoreapp. > > Please delete PathFeatures.cs and all references to it. Assume that all Path features are available and no legacy behaviors are present. > > ## Comments on the Issue (you are @copilot in this section) > > > >

Fixes dotnet/runtime#120928 --- 💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click [here](https://survey3.medallia.com/?EAHeSx-AP01bZqG0Ld9QLQ) to start the survey. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com> Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

PathFeatures.cs is dead code #120928

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions