Conversation
…ad of 1 …" This reverts commit 9fb66db.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous change that increased the Brotli compression quality for CompressionLevel.Fastest from 1 to 2. The revert is necessary because the quality increase caused significant performance degradation (up to 80% slowdown in some benchmarks) when batching input, which is the expected usage pattern.
Key Changes
- Reverts Brotli
CompressionLevel.Fastestquality from 2 back to 1 - Removes comment explaining the rationale for using quality 2
- Restores original performance characteristics for batched compression scenarios
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-io-compression |
rokonec
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #120433
Closes #120711
Unfortunately, increasing the quality decreases performance when batching the input (as is the expected usage). And the large (in some benchmarks up to 80% slowdown) performance hit does not justify fixing the small writes scenario this way.