Enable continuing after assert in interpreter on macOS#121005
Merged
janvorli merged 1 commit intodotnet:mainfrom Oct 23, 2025
Merged
Enable continuing after assert in interpreter on macOS#121005janvorli merged 1 commit intodotnet:mainfrom
janvorli merged 1 commit intodotnet:mainfrom
Conversation
This change changes __builtin_trap() that we use to break into the debugger on assert to __builtin_debugtrap() on macOS. The former doesn't allow continuing after the assert while the latter does.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables developers to continue execution after hitting an assert in the CoreCLR interpreter when debugging on macOS. The change replaces __builtin_trap() with __builtin_debugtrap() for Apple targets, as the former terminates the process while the latter allows resuming after the debugger breakpoint.
Key Changes:
- Modified the
assertAbortfunction to use__builtin_debugtrap()on macOS instead of__builtin_trap()
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change changes __builtin_trap() that we use to break into the debugger on assert to __builtin_debugtrap() on macOS. The former doesn't allow continuing after the assert while the latter does.