Validate that an IPv6 Uri host is followed by expected delimiters#120908
Merged
MihaZupan merged 1 commit intodotnet:mainfrom Oct 21, 2025
Merged
Validate that an IPv6 Uri host is followed by expected delimiters#120908MihaZupan merged 1 commit intodotnet:mainfrom
MihaZupan merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a URI parsing bug where IPv6 addresses followed by invalid characters (without proper delimiters) would incorrectly succeed and hallucinate path components. For example, http://[::]extra would previously parse successfully with /extra as the path, when it should fail.
Key Changes:
- Added validation to ensure IPv6 host addresses are followed by valid delimiters (
:,/,?,#, or end of string) - Enhanced test coverage with multiple scenarios testing both invalid cases and valid delimiter combinations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Private.Uri/src/System/Uri.cs | Added delimiter validation after IPv6 address parsing to reject malformed URIs |
| src/libraries/System.Private.Uri/tests/FunctionalTests/UriIpHostTest.cs | Refactored test helper and added comprehensive test cases for delimiter validation |
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an input like
http://[::]extra, we would previously hallucinate a slash after the], so parsing would succeed andAbsolutePathwould return/extra.This change enforces that the
]is followed by a delimiter, same as we do for all other host types.