Remove pkgproj projects that can be easily replaced by .NET SDK pack support#120853
Merged
jkoritzinsky merged 5 commits intodotnet:mainfrom Oct 21, 2025
Merged
Remove pkgproj projects that can be easily replaced by .NET SDK pack support#120853jkoritzinsky merged 5 commits intodotnet:mainfrom
jkoritzinsky merged 5 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request modernizes package creation by replacing legacy .pkgproj projects with .NET SDK's native pack support, directly implementing package metadata in the source projects themselves.
Key Changes:
- Converted ILVerify, ILVerification, and ILCompiler.Reflection.ReadyToRun to use SDK-style packaging
- Migrated Microsoft.NET.Sdk.IL from
.pkgprojto.projwith SDK-style packaging - Consolidated shared packaging logic into reusable
pkgproj.propsandpkgproj.targetsfiles
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ILCompiler.Reflection.ReadyToRun.csproj | Added IsPackable and package metadata properties |
| ILVerify.csproj | Added packaging properties for dotnet tool support |
| ILVerification.csproj | Added package metadata and release notes |
| pkgproj.targets | New shared packaging targets for symbol file handling |
| pkgproj.props | New shared packaging properties for .pkgproj projects |
| dotnet-ilverify.pkgproj | Deleted legacy packaging project |
| DotnetToolSettings.xml | Deleted obsolete tool settings file |
| coreclr-packages.proj | Updated to reference new SDK-style projects |
| Microsoft.NET.Sdk.IL.proj | New SDK-style packaging project |
| Microsoft.NET.Sdk.IL.pkgproj | Deleted legacy packaging project |
| Microsoft.NET.Sdk.IL/Directory.Build.targets | New targets file with packaging logic |
| Microsoft.NET.Sdk.IL/Directory.Build.props | New props file to control pkgproj usage |
| Microsoft.ILVerification.pkgproj | Deleted legacy packaging project |
| ILCompiler.Reflection.ReadyToRun.Experimental.pkgproj | Deleted legacy packaging project |
| .nuget/Directory.Build.targets | Simplified to import shared pkgproj.targets conditionally |
| .nuget/Directory.Build.props | Simplified to import shared pkgproj.props conditionally |
| Subsets.props | Added ILVerify and ILVerification to build list |
src/coreclr/.nuget/Microsoft.NET.Sdk.IL/Microsoft.NET.Sdk.IL.proj
Outdated
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @hoyosjs |
This was referenced Oct 18, 2025
Open
agocke
reviewed
Oct 21, 2025
agocke
approved these changes
Oct 21, 2025
Member
|
@jkoritzinsky After this PR got merged in, I randomly hit build errors like: and they go away on the 2nd attempt. |
Member
|
Ah, I didn't notice #121068 was already filed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #75966