[cDAC] bugfix for threadstatics stored directly on ThreadLocalData#120922
Merged
rcj1 merged 1 commit intodotnet:mainfrom Oct 21, 2025
Merged
[cDAC] bugfix for threadstatics stored directly on ThreadLocalData#120922rcj1 merged 1 commit intodotnet:mainfrom
rcj1 merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the thread-local static base address calculation for the DirectOnThreadLocalData case. The fix ensures that when thread-local statics are stored directly on ThreadLocalData, the index offset is properly added to the base pointer instead of returning just the base pointer.
Key Changes
- Corrected the calculation of
threadLocalStaticBaseto include theindexOffsetwhen handlingDirectOnThreadLocalDataTLS index type - Updated both implementation code and documentation to reflect the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/Thread_1.cs | Fixed bug by adding indexOffset to threadLocalDataPtr for DirectOnThreadLocalData case |
| docs/design/datacontracts/Thread.md | Updated documentation to match the corrected implementation |
hoyosjs
approved these changes
Oct 20, 2025
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
max-charlamb
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.