Add johha to ARI approvers #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
approved these changes
Jun 29, 2022
Member
philippthun
left a comment
There was a problem hiding this comment.
Having Johannes on board would be great!
Member
|
Per https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0008-role-change-process.md#promotion-to-approver, you need 2 existing approvers to review your application. I see @philippthun already approved the promotion, so you will need one more. Once that criteria is met, I'll merge this PR. Depending on the state of the Github teams automation, I may also need to update https://github.com/cloudfoundry/community/blob/ac5ce430d66098325a6b1fcf76356af17601ccad/org/cloudfoundry.yml to grant you access to the appropriate teams. |
FloThinksPi
approved these changes
Jun 30, 2022
Gerg
approved these changes
Jul 5, 2022
Member
|
I'll make a follow-up PR to add @johha to the appropriate teams. |
Gerg
added a commit
that referenced
this pull request
Jul 5, 2022
Follow up to [#329] Authored-by: Greg Cobb <gcobb@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About Me
I'm a senior developer at SAP working together with @philippthun, @FloThinksPi, @jochenehret, @stephanme on operating and improving Capi and related projects.
Contributions
In the past ~18 months I was involved in a number for contributions, discussions etc. which qualifies me to be a approver for Capi.
CVEs
Label_selectors CVE: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22101
Issues
Unusable Buildpacks: cloudfoundry/cloud_controller_ng#1625
Slack Conversations
Service credential bindings discussion: https://cloudfoundry.slack.com/archives/C07C04W4Q/p1640160640057900
Suspended orgs/ user permissions: https://cloudfoundry.slack.com/archives/C07C04W4Q/p1637252694022900
capi-releaseKey rotation(merged manually): cloudfoundry/capi-release#119
Nginx timeout parameter: cloudfoundry/capi-release#188
Nginx drain parameter: cloudfoundry/capi-release#189
User header: cloudfoundry/capi-release#191
Job priorities parameter: cloudfoundry/capi-release#227
Access log escaping (co-author): cloudfoundry/capi-release#192
Fog debug environment variable (co-author): cloudfoundry/capi-release#185
cloud_controller_ngBetter error message for active org check (in progress, co-author): cloudfoundry/cloud_controller_ng#2570
CC worker logging (co-author): cloudfoundry/cloud_controller_ng#1995
Retry polling (co-author): cloudfoundry/cloud_controller_ng#2413
Deserialization spec for SpaceApplyManifestActionJob: cloudfoundry/cloud_controller_ng#2782
Logging of deserialization errors: cloudfoundry/cloud_controller_ng#2771
Configurable delayed job priorities: cloudfoundry/cloud_controller_ng#2693
Simplify roles query (co-author): cloudfoundry/cloud_controller_ng#2532
Logging of sql query lengths: cloudfoundry/cloud_controller_ng#2329
Logging of sql returned rows (co-author): cloudfoundry/cloud_controller_ng#2338
Window functions (co-author): cloudfoundry/cloud_controller_ng#2527
User guid header: cloudfoundry/cloud_controller_ng#2167
Enhance Nginx drain: cloudfoundry/cloud_controller_ng#2150
Nginx timeout: cloudfoundry/cloud_controller_ng#2138
Update fog-azure-rm dependency (co-author): cloudfoundry/cloud_controller_ng#1925
cf-performance-testsAdd pipeline for re-running old cf-d versions: cloudfoundry/cf-performance-tests-pipeline#23
Improve data generation in test setup: cloudfoundry/cf-performance-tests#17