Simplify roles query for performance #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backing dataset for the Role class uses a UNION between all the different org and space roles where the organization_id is -1 for space roles and vice versa. This means that no role can have both a space_id and an org_id so doing a SELECT WHERE space_id IN (space_ids) and UNION that to SELECT WHERE org_id in (org_ids) can be replaced by just a single select with an OR in the query clause In our largest environments this reduced the complexity of this query (using EXPLAIN ANALYZE) by nearly 30x Co-Authored-By: Andy Paine <andrew.paine@sap.com> Co-Authored-By: Johannes Haass <johannes.haass@sap.com>
Member
|
Ran CATS on PR. Hit the endpoint a few different ways. Examined CCNG's logs. Everything looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Replace UNION-ed subqueries with single subquery and WHERE OR clause
An explanation of the use cases your change solves
The many UNIONs (14 in total) were causing these queries to be extremely complex and slow on our largest landscapes resulting in impact to other queries being made (lots of temp blocks being written). This change simplifies the query so much it no longer needs temp blocks.
Added context
The backing dataset for the Role class uses a UNION between all the
different org and space roles where the organization_id is -1 for space
roles and vice versa. This means that no role can have both a space_id
and an org_id so doing a SELECT WHERE space_id IN (space_ids) and UNION
that to SELECT WHERE org_id in (org_ids) can be replaced by just a
single select with an OR in the query clause
In our largest environments this reduced the complexity of this query
(using EXPLAIN ANALYZE) by nearly 30x
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests