Log caller and query length for sql queries #2329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs the calling function (of cloud_controller_ng code) for each DB query if SQL logging is enabled. This should help track down which functions are calling expensive queries and where excessive queries are being made. Running some perf tests against this, it appears to have little to no impact on the performance of CC since I suspect all this information is readily available in the callstack and the regex isn't too complex
We've seen some queries get extremely long (>1MB) which causes CC to run slow whilst building the query. To help monitor this and fix endpoints generating large queries, log the character length of the query in the SQL query logging string Co-authored-by: johha <45264872+johha@users.noreply.github.com>
sweinstein22
approved these changes
Jun 30, 2021
Contributor
sweinstein22
left a comment
There was a problem hiding this comment.
Ran through a quick check to see the behavior introduced:
ssh'd onto the api vm for the boshlite
Manually adjusted the cloud controller config's db section to include log_level: "info" and log_db_queries: true.
Ran monit restart cloud_controller_ng, waited for the restart to complete, ran cf curl /v3/security_groups
Checked cloud_controller_ng.log on the api instance, confirmed that query_length now appears as part of output:
{"timestamp":"2021-06-30T21:23:32.543213998Z","message":"(0.000497s) (app/presenters/v3/security_group_presenter.rb:45:in `space_guid_hash_for') (query_length=217) SELECT `guid` FROM `spaces` INNER JOIN `staging_security_groups_spaces` ON (`staging_security_groups_spaces`.`staging_space_id` = `spaces`.`id`) WHERE (`staging_security_groups_spaces`.`staging_security_group_id` = 3)","log_level":"info",...}
The changes look good, thanks for the PR!
will-gant
pushed a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Jul 12, 2021
* Log caller for SQL queries Logs the calling function (of cloud_controller_ng code) for each DB query if SQL logging is enabled. This should help track down which functions are calling expensive queries and where excessive queries are being made. Running some perf tests against this, it appears to have little to no impact on the performance of CC since I suspect all this information is readily available in the callstack and the regex isn't too complex * Add extension to log SQL query length We've seen some queries get extremely long (>1MB) which causes CC to run slow whilst building the query. To help monitor this and fix endpoints generating large queries, log the character length of the query in the SQL query logging string Co-authored-by: johha <45264872+johha@users.noreply.github.com> Co-authored-by: andy-paine <andy.paine@engineerbetter.com>
bepotts
pushed a commit
that referenced
this pull request
Jul 13, 2021
* Log caller for SQL queries Logs the calling function (of cloud_controller_ng code) for each DB query if SQL logging is enabled. This should help track down which functions are calling expensive queries and where excessive queries are being made. Running some perf tests against this, it appears to have little to no impact on the performance of CC since I suspect all this information is readily available in the callstack and the regex isn't too complex * Add extension to log SQL query length We've seen some queries get extremely long (>1MB) which causes CC to run slow whilst building the query. To help monitor this and fix endpoints generating large queries, log the character length of the query in the SQL query logging string Co-authored-by: johha <45264872+johha@users.noreply.github.com> Co-authored-by: andy-paine <andy.paine@engineerbetter.com>
bepotts
pushed a commit
that referenced
this pull request
Jul 19, 2021
* Log caller for SQL queries Logs the calling function (of cloud_controller_ng code) for each DB query if SQL logging is enabled. This should help track down which functions are calling expensive queries and where excessive queries are being made. Running some perf tests against this, it appears to have little to no impact on the performance of CC since I suspect all this information is readily available in the callstack and the regex isn't too complex * Add extension to log SQL query length We've seen some queries get extremely long (>1MB) which causes CC to run slow whilst building the query. To help monitor this and fix endpoints generating large queries, log the character length of the query in the SQL query logging string Co-authored-by: johha <45264872+johha@users.noreply.github.com> Co-authored-by: andy-paine <andy.paine@engineerbetter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
For better analyzing load pattern we want to log the caller and length of db queries. This is related to the slow requests we found recently (e.g.
security_groups)Log example:
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests