Add separate check for active org #2570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2022
fb031e7 to
4614fd9
Compare
philippthun
reviewed
Mar 2, 2022
32a3ba6 to
e7b42b4
Compare
philippthun
reviewed
Mar 24, 2022
452cff2 to
50bc0fa
Compare
philippthun
reviewed
Apr 25, 2022
5 tasks
b92d618 to
943a186
Compare
The checks if an org is suspended and the user has write permissions are implemented in the same method. Thus an 'unauthorized' error could be misleading if a user is e.g. space developer but the org is suspended. With this PR the check for a suspended org is moved into a dedicated method and all controllers have been adapted to return a different error in case the user has write permissions but the org is suspended (still an HTTP 403 error but with a different message). Co-authored-by: Johannes Haass <johannes.haass@sap.com> Co-authored-by: Philipp Thun <philipp.thun@sap.com>
943a186 to
ba2fea5
Compare
philippthun
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks if an org is suspended and the user has write permissions are implemented in the same method. Thus an 'unauthorized' error could be misleading if a user is e.g. space developer but the org is suspended. With this PR the check for a suspended org is moved into a dedicated method and all controllers have been adapted to return a different error in case the user has write permissions but the org is suspended (still an HTTP 403 error but with a different message).
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests