Fix broken logging for cc_workers #1995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We found that in cloud controller worker environments the logger is set before steno is initialised. This leads to cc.background type logs not being emitted as all steno sinks are missing for the respective logger. This commit reorders the logger initialisation to be after steno init. Co-authored-by: Johannes Haass <45264872+johha@users.noreply.github.com>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/176057635 The labels on this github issue will be updated when the story is started. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
@FloThinksPi Can you a deploy a fixed version of this and see that things are being logged correctly? |
Member
Author
|
@weymanf yes we could observe more logging again with this patch on a real landscape: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that our cc_workers do not log db-queries and anymore.
Maybe they do not log anything, we did not go in depth what is logged and what not.
We found that in cloud controller worker environments the logger is set before steno is
initialised.
This leads to cc.background type logs not being emitted as all steno sinks
are missing for the respective logger.
This PR reorders the logger initialisation to be after steno init.
With this we see logs being correctly emitted again.
We need logs 😃
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
masterbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests