Shutdown nginx timeout #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Philipp Thun <philippthun@users.noreply.github.com>
Co-authored-by: Philipp Thun <philippthun@users.noreply.github.com>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/177160218 The labels on this github issue will be updated when the story is started. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to the
capi_release. To speed up the process of reviewing your pull request please provide us with:A short explanation of the proposed change:
Currently the nginx timeout for graceful shutdown is hard coded to 30 secs. If requests take longer than this (e.g.
v2/serviceson big foundries) they'll be terminated. Making this configurable will allow operators to prevent (too many) failed requests during monit restarts. Seecloud_controller_ngMake nginx timeout configurable cloud_controller_ng#2138.For the same reason the number of monit cycles for detecting constant high memory consumption should be configurable.
Links to any other associated PRs:
Make nginx timeout configurable cloud_controller_ng#2138
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite