Hide user guid header from client #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* X-USER-GUID can be used in nginx access logs Consumption in nginx conf: 'user_guid=$upstream_http_x_user_guid' Co-authored-by: Philipp Thun <philippthun@users.noreply.github.com>
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/177492068 The labels on this github issue will be updated when the story is started. |
5 tasks
Member
|
LGTM. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Hide header
X-USER-GUIDfrom client. Header was newly introduced in cc_ng with Set additional header with user guid cloud_controller_ng#2167It can be used in nginx access logs, e.g. with
user_guid=$upstream_http_x_user_guidThis makes it easier for us track/ debug requests with the nginx logs.
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite