Retry polling on broker errors in V3 #2413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In V2 service broker HTTP errors would be retried until successful. * In V3 a service broker HTTP error would immediately mark the instance as failed. * By retrying HTTP errors in the V3 action CC can be more resilient against failing service brokers. Signed-off-by: Andrew Paine <andrew.paine@sap.com> Signed-off-by: Johannes Haass <45264872+johha@users.noreply.github.com>
Member
|
LGTM! Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
By retrying HTTP errors in the V3 action CC can be more resilient against failing service brokers.
An explanation of the use cases your change solves
In V2 service broker HTTP errors would be retried until successful. In V3 a service broker HTTP error would immediately mark the instance as failed.
Fixes #2354
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests