Skip to content

Conversation

@johha
Copy link
Contributor

@johha johha commented Jan 17, 2019

As outlined in #114 we have logging enabled for cc and this causes the rotate key errand to fail on bigger landscapes with too many log messages. Thus we want to set the log level for the errand specifically. We do not change the previous behavior, i.e. if not provided the cc log level will be used. The added properties are optional.

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

    • Not applicable to this change, as it does not affect component functionality
    • We created a dev release and tested the errand with different logging levels

Signed-off-by: Johannes Haass <johannes.haass@sap.com>
@cfdreddbot
Copy link

❌ Hey johha!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process.

The following github user @johha is not covered by a CLA.

After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s).

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/163286431

The labels on this github issue will be updated when the story is started.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/163286453

The labels on this github issue will be updated when the story is started.

@cfdreddbot
Copy link

✅ Hey johha! The commit authors and yourself have already signed the CLA.

@monamohebbi
Copy link
Contributor

Merged manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants