Add deserialization test for SpaceApplyManifestActionJob #2782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b624170 to
7247d7f
Compare
7247d7f to
3489190
Compare
Related to discussion on cloudfoundry#2748 - Compares if new SpaceApplyManifestActionJob equals dumped one - Checks if dumped job can be deserialized
3489190 to
6febe0b
Compare
0370032 to
e8c08b0
Compare
12df6db to
328a548
Compare
philippthun
approved these changes
May 4, 2022
684c7b1 to
a74060c
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
During an update of the api and worker nodes deserialization errors can occur when the format changes, e.g. due to a updated dependency. This change adds a test to ensure that a SpaceApplyManifestActionJob serialization format does not change and can be deserialized.
Related to [Post-Mortem] Deserialization errors caused by Rails update #2748
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests