Skip to content

Qos #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MGaetan89 merged 38 commits into from
Sep 12, 2024
Merged

Qos #694

MGaetan89 merged 38 commits into from
Sep 12, 2024

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Sep 9, 2024 •
edited
Loading

Pull request

Description

First implementation of the Monitoring specification defined here

Currently the monitoring doesn't send data to a real server!

Changes made

  • Add playback metrics statistics PlaybackMetrics.
  • PlaybackSessionManager to handle playback session.
  • Display playback metrics inside the demo.

Checklist

  • Your branch has been rebased onto the main branch.
  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).
  • All pull request status checks pass.

@StaehliJ StaehliJ requested a review from MGaetan89 September 9, 2024 13:24
@MGaetan89 MGaetan89 added this to the QoS milestone Sep 10, 2024
@github-actions
Copy link

github-actions bot commented Sep 10, 2024 •
edited
Loading

Code Coverage

Overall Project 50.49% -4.91% 🟢
Files changed 75.23% 🟢

Module Coverage
:pillarbox-core-business 80.41% -0.08% 🟢
:pillarbox-player 60.17% -8.87% 🟢
:pillarbox-ui 0.06% -0.78% 🟢
Files
Module File Coverage
:pillarbox-core-business HttpMediaCompositionService.kt 100% 🟢
CommandersActStreaming.kt 95.31% 🟢
AkamaiTokenProvider.kt 72.36% 🟢
DefaultPillarbox.kt 51.61% -3.23% 🟢
DefaultHttpClient.kt 0% 🟢
:pillarbox-player PillarboxLoadControl.kt 100% 🟢
EventTime.kt 100% 🟢
Heartbeat.kt 98.52% -1.48% 🟢
PillarboxHttpClient.kt 97.8% -2.2% 🟢
PlaybackMetrics.kt 97.39% -2.61% 🟢
SessionMetrics.kt 94.35% -5.65% 🟢
LoadingTimes.kt 94.3% -5.7% 🟢
PlaybackSessionManager.kt 92.97% -7.03% 🟢
Monitoring.kt 89.77% -10.23% 🟢
PillarboxMediaSource.kt 88.39% -6.7% 🟢
TotalPlaytimeCounter.kt 85.71% -9.09% 🟢
ErrorMessageData.kt 84.72% -15.28% 🟢
PillarboxExoPlayer.kt 83.48% -4.01% 🟢
StallDetector.kt 82.43% -17.57% 🟢
EventMessageData.kt 76.95% -23.05% 🟢
Message.kt 76.03% -23.97% 🟢
PlayerCallbackFlow.kt 70.44% -1.65% 🟢
PillarboxEventLogger.kt 69.92% -7.52% 🟢
MetricsCollector.kt 67.97% -32.03% 🟢
PillarboxAnalyticsCollector.kt 64.19% -11.49% 🟢
Session.kt 58.12% -41.88% 🟢
PillarboxMediaSourceFactory.kt 54.6% 🟢
Player.kt 39.57% -3.04% 🟢
Timings.kt 18.18% -81.82% 🟢
MonitoringMessageHandler.kt 11.96% -88.04% 🟢
PillarboxAnalyticsListener.kt NaN% NaN% 🟢
MessageData.kt 0% 🟢
BitrateUtil.kt 0% 🟢
:pillarbox-ui ComposablePlayer.kt 0% -5.41% 🟢

@StaehliJ StaehliJ requested a review from MGaetan89 September 11, 2024 08:54
MGaetan89 and others added 23 commits September 12, 2024 09:00
@MGaetan89 @StaehliJ
Add models for QoS and an AnalyticsListener to gather session load …
b7d9fa6 
…times (#596)

Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
@StaehliJ @MGaetan89
592 playback session manager (#597)
b759454 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@MGaetan89
Link PlaybackSessionManager with QoSSessionAnalyticsListener (#609)
31cfb5e
@StaehliJ @MGaetan89
604 collect stalls metrics (#610)
e325f68 
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
@MGaetan89
Enable CI on the qos branch (#615)
bbbc21e
@StaehliJ @MGaetan89
619 enhance sessionmanager with perioduid (#627)
de51c7d
@StaehliJ @MGaetan89
625 consolidate metrics management (#632)
bc9b332 
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@MGaetan89
Extract session management out of QoSEventsDispatcher (#635)
f1f8ebe
@StaehliJ @MGaetan89
631 metrics collector (#638)
2628d7b 
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@StaehliJ @MGaetan89
Improve metrics collector (#644)
602f8e7 
Co-authored-by: Gaëtan Muller <gaetan.muller@rts.ch>
@MGaetan89
Create line and bar chart components for the demo (#645)
95824fb
@MGaetan89
Remove usage of List.removeIf (#657)
1a9e06b
@StaehliJ @MGaetan89
Metrics collector UI (#655)
f228d5b 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@MGaetan89 @StaehliJ
Update heartbeat behavior (#656)
117014e 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
@MGaetan89 @StaehliJ
Update models for QoS (#654)
9c83018 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
@MGaetan89
Remove old QoS models (#667)
b5fa99d
@MGaetan89
Display metrics overlay in the TV demo and add a dedicated setting (#666
7544aa4 
)
@MGaetan89
Create mobile screen for QoS (#670)
f587721
@StaehliJ @MGaetan89
Finish sessions when player change state to STATE_IDLE.
759d30d 
STATE_IDLE is reached after call stop or release.
@StaehliJ @MGaetan89
Already handled by playback state changes
55970c7
@StaehliJ @MGaetan89
Send session start before sending error event if needed
b4be489
@StaehliJ @MGaetan89
Don't handle session on this callback
5ee8b59 
onAudioPositionAdvancing may be call after releasing the player. So it avoid recreating a Session when the player is IDLE.
@StaehliJ @MGaetan89
Add some debug logs
0dd2c1d
StaehliJ and others added 14 commits September 12, 2024 09:01
@StaehliJ @MGaetan89
MetricsSession should be created when a PlaybackSession is created.
3aeb838
@StaehliJ @MGaetan89
Store base asset url for each periodUid
19f0753
@StaehliJ @MGaetan89
Use Secure.ANDROID_ID for device
736ea46
@StaehliJ @MGaetan89
Fix test
d01b4f2
@StaehliJ @MGaetan89
Improve qos coordinator (#677)
2ef16a7 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@StaehliJ @MGaetan89
680 fix position playbacksession (#683)
a0863b7 
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
@MGaetan89 @StaehliJ
Update QoS models to match the latest specification (#678)
cb108fb 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
@MGaetan89 @StaehliJ
Add backend integration for QoS event (#688)
3d1af20 
Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
@StaehliJ @MGaetan89
Rename Monitoring
9606f1b
@MGaetan89
Remove qos from buildable branches
4041705
@MGaetan89
Continue monitoring renaming
860064e
@StaehliJ @MGaetan89
Fully embrace the Monitoring renaming
db32da6
@StaehliJ @MGaetan89
Fix rebase
2b4d732
@MGaetan89
Fix Detekt warnings
1e052f5
@MGaetan89 MGaetan89 enabled auto-merge September 12, 2024 07:37
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2024
@MGaetan89 MGaetan89 added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit f65758a Sep 12, 2024
@MGaetan89 MGaetan89 deleted the qos branch September 12, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MGaetan89 MGaetan89 MGaetan89 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StaehliJ StaehliJ

Labels

None yet

Projects

Pillarbox
Archived in project

Milestone

QoS

Development

Successfully merging this pull request may close these issues.

2 participants

@StaehliJ @MGaetan89