Metrics collector UI #655
Merged
Metrics collector UI #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
MGaetan89
reviewed
Jul 26, 2024
...mo-shared/src/main/java/ch/srgssr/pillarbox/demo/shared/ui/settings/MetricsOverlayOptions.kt
Show resolved
Hide resolved
| val appSettingsRepository = remember { | ||
| AppSettingsRepository(context) | ||
| } | ||
| val appSettings by appSettingsRepository.getAppSettings().collectAsStateWithLifecycle(AppSettings()) |
Contributor
There was a problem hiding this comment.
Why not use the AppSettingsViewModel here?
Contributor
Author
There was a problem hiding this comment.
We could yes, in won't be short to write and the viewmodel will be scoped to the Activity if I'm not wrong.
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/ui/player/PlayerView.kt
Show resolved
Hide resolved
pillarbox-demo/src/main/java/ch/srgssr/pillarbox/demo/MainNavigation.kt
Outdated
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/utils/BitrateUtil.kt
Show resolved
Hide resolved
pillarbox-player/src/main/java/ch/srgssr/pillarbox/player/utils/BitrateUtil.kt
Outdated
Show resolved
Hide resolved
e32129c to
acd574b
Compare
Code Coverage
Files
|
8a29727 to
24e94a5
Compare
Also update `CustomPlaybackSettingsShowcase` to have the same behavior
f5a8911 to
7577e27
Compare
MGaetan89
added a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Aug 12, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Aug 13, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
StaehliJ
added a commit
that referenced
this pull request
Aug 28, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
StaehliJ
added a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Sep 12, 2024
Co-authored-by: Gaëtan Muller <m.gaetan89@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
The Goal of this PR is to had a metrics overlay into the demo. The overlay can be enabled and customized in the new tab "setting"
Changes made
PlaybackMetrics.Checklist
mainbranch.