Add models for QoS and an AnalyticsListener to gather session load times
#596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces unit tests for the following QoS classes: - `QoSError` - `QoSSession` - `QoSSessionTimings` These tests ensure the correct behavior of these classes and provide a safety net for future development.
f53739c to
3601503
Compare
Code Coverage
Files
|
StaehliJ
requested changes
Jun 20, 2024
StaehliJ
approved these changes
Jun 21, 2024
StaehliJ
added a commit
that referenced
this pull request
Jun 26, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
6 tasks
MGaetan89
added a commit
that referenced
this pull request
Jul 9, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Jul 11, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Jul 17, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Jul 29, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Jul 30, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Aug 12, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Aug 13, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Aug 20, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
StaehliJ
added a commit
that referenced
this pull request
Aug 28, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
StaehliJ
added a commit
that referenced
this pull request
Sep 11, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
MGaetan89
added a commit
that referenced
this pull request
Sep 12, 2024
…times (#596) Co-authored-by: Joaquim Stähli <joaquim.staehli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Description
This PR adds the models needed for QoS (session, event, error, message). It also adds a custom
AnalyticsListenerto measure the load times of a media, and report them in the QoS session.Changes made
AnalyticsListeneronPillarboxExoPlayerto observe media load times.BuildConfig.VERSION_NAMEfield.Checklist
mainbranch.